]> git.koha-community.org Git - koha.git/commit
Bug 16671: (bug 14828 follow-up) Pick the right itemtypes
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Jun 2016 13:00:56 +0000 (14:00 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 8 Jul 2016 12:47:13 +0000 (12:47 +0000)
commit8f42c681b0208ace7ed7858cafdd8c9777debd96
tree714d58dca06892e59211af2c8821c0e74ccac300
parent3bb51d038639c7b197022a2c7c6ae864c834060f
Bug 16671: (bug 14828 follow-up) Pick the right itemtypes

Looking at commit aafe73eefb5151454fa8957bf188768324d23955
  Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used
-my @item_types = C4::ItemType->all;
-my @for_loan = grep { $_->{notforloan} == 0 } @item_types
-  or BAIL_OUT("No adequate itemtype");
-my $itemtype = $for_loan[0]->{itemtype};
+my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next;
+$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype = $itemtype->itemtype

It seems that the tests expect itemtypes for loan.

Test plan:
  prove t/db_dependent/HoldsQueue.t
should still return green

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. No qa test tool errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Adding follow-up.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/HoldsQueue.t