]> git.koha-community.org Git - koha.git/commit
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 6 Jan 2022 10:13:57 +0000 (07:13 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 18 Jan 2022 00:55:56 +0000 (14:55 -1000)
commit8ffd26dc99541b62e8d261d29e5959b6cfe4be20
tree5e8263ee8d5b6bc971fdfb6ed7f1d2a6feb1a20a
parent28816cf55bdd9142659a18891cd3da42ba6cf804
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding

This trivial patch acknowledges the fact bug 28871 is probably not going
to be pushed, and changes the method so  it, internally, uses
Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in
scalar context.

This is probably the correct solution as the discussion on bug 28883
points towards the future removal of the use of wantarray altogether,
eventually.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> FAIL: It explodes as we see in production, with:
The method Koha::Libraries->branchcode is not covered by tests!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Hold.pm