]> git.koha-community.org Git - koha.git/commit
Bug 22778: Suggestions with no "suggester" can cause errors
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 25 Apr 2019 19:50:35 +0000 (15:50 -0400)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 14 Apr 2020 07:19:21 +0000 (08:19 +0100)
commit94ed64e5b1e348fcd06d2d41b880c52b6822df57
treecf73258dc93f2aabcba7b41bd9ac2c08fd1d2dd7
parent479474e532dca6ded90770fc7a0c00500ea4f787
Bug 22778: Suggestions with no "suggester" can cause errors

If one tries to modify a suggestion that has no suggester you will get the following error:

Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506

Koha assumes that every suggestion has a borrowernumber in suggestedby

Test Plan:
1) Create a suggestion with an unpopulated suggestedby
2) Attempt to modify that suggestion
3) Note the error
4) Apply this patch
5) Restart all teh things
6) Attempt to modify that suggestion
7) No error!

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Suggestions.pm