]> git.koha-community.org Git - koha.git/commit
Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc)
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 22 Feb 2021 11:46:44 +0000 (13:46 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Apr 2021 13:25:26 +0000 (15:25 +0200)
commita34e1f9f0d32e4cf0f282016e52166d309b25ef7
tree4b7a99450c7227742fb0d41845eb6cb7f6d07bf9
parentc30c8c7a5367cb68bd1a2db16972f8668a630282
Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc)

Some of the books have subfield "a" of field "035" absent
and it's possible to have such
(it doesn't says "Require" in the interface),
which causes "Use of uninitialized value $oclc in pattern match (m//)"
error.

Solved by screening regex with check for empty variables before the
match.

To reproduce:
    1) Edit existing book or create a new one with empty marc
subfield "a" of field "035"
    2) Use the search feature that will find it along with some other
books.
    3) Check /var/log/koha/kohadev/plack-intranet-error.log to find
"Use of uninitialized value $oclc in pattern match (m//)" error.
    4) Apply the patch.
    5) Repeat the search and check the logs again to ensure
that error didn't appear again.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Koha.pm