]> git.koha-community.org Git - koha.git/commit
Bug 16446: Add ability to add patrons to list by borrowernumber
authorNick Clemens <nick@bywatersolutions.com>
Fri, 27 Aug 2021 12:39:49 +0000 (12:39 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 21 Oct 2021 10:24:04 +0000 (12:24 +0200)
commitad1d734e548809ab7534545a1b2c7c936ae542eb
treea914db134482e1b7f6a9d9a6712cced8ac57bd77
parente5d5623ee26d9fdcee13aea87a2ccbdd01ee7876
Bug 16446: Add ability to add patrons to list by borrowernumber

AddPatronsToList already took a borrowernumber parameter, however, it
did not check if those were valid numbers. This patch expands the search
to apply to cardnumber or borrowernumbers in the subroutine.

Template and script are adjusted to allow choosing borrowernumbers or cardnumbers

To test:
1 - Apply patch
2 - Browse to Tools->Patron lists
3 - Create a list, or choose Actions->Add patrons for an existing list
4 - Click 'Add multiple patrons'
5 - Cardnumbers is preselected
6 - Enter a list of cardnumbers, ensure you test:
    Cardnumber already in list
    Cardnumber not in list
    Non-existent cardnumber
7 - Patrons should be added/errors reported correctly
8 - Repeat with borowernumbers

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/List/Patron.pm
koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
patron_lists/list.pl
t/db_dependent/PatronLists.t