]> git.koha-community.org Git - koha.git/commit
Bug 8443: Suggestions publication year and copyright date (follow-up 2) Cosmetic...
authorFridolyn SOMERS <fridolyn.somers@biblibre.com>
Tue, 6 Nov 2012 11:10:46 +0000 (12:10 +0100)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 16 Jan 2013 03:10:59 +0000 (22:10 -0500)
commitbc7142857164a602150ad64bb0ef334764e72fcd
tree7554d5d6f35c85a0dbd9c9336faa9017abd77f95
parent13bebe6b34d4f34f956cb4083c5284d6984b130b
Bug 8443: Suggestions publication year and copyright date (follow-up 2) Cosmetic changes and perltidy formatting

Cosmetic patch :

Manual editions :
- use of () for qw
- use of q{} or qq{} in SQL queries
- replacing $${key} by $->{key}
- formatting SQL queries (easier to read)
- in suggestion.tt reducing date input size to allow calendar icon on same line

+ Formatting with perltidy

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests were done with all 3 patches from this bug applied:

1) Add suggestion from OPAC, check copyright date is saved
2) Add suggestion in intranet, check copyright date is saved
3) Edit suggestion, check change is saved correctly
4) Check date filters work as expected, using single dates, date ranges
   and multiple filters at once:
  - Accepted on
  - Managed on
  - Suggested on
5) Check copyright date search works correctly.

Passes all tests and QA script.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Suggestions.pm
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt