]> git.koha-community.org Git - koha.git/commit
Bug 17978: Circ rules will not limit holds
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 19 Dec 2017 19:20:56 +0000 (14:20 -0500)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 10 Apr 2019 19:59:28 +0000 (19:59 +0000)
commitd7a5925aa0a7a185c8671d8c9989d80bdf2c0939
tree4e2dd6397b2cef9b464e4a490c7160f928f5e62f
parente98dacf9f1f8464f0db394da6bc1152f96713597
Bug 17978: Circ rules will not limit holds

The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose.

Test Plan:
1) Set ReservesControlBranch to "item's home library"
2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds
3) Place 3 record level holds, you can but you should not be able to!
4) Delete the holds
5) Apply this patch
6) Attempt to place 3 record level holds
7) Note that you cannot!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Reserves.pm