]> git.koha-community.org Git - koha.git/commit
Bug 7688: (follow-up) rewrite t/db_dependant/Serials.t
authorJulian Maurice <julian.maurice@biblibre.com>
Mon, 8 Apr 2013 12:04:45 +0000 (12:04 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 30 Oct 2013 00:35:38 +0000 (00:35 +0000)
commitd93ec41012fb7c30effecb66eab41c6c14805c29
tree99cc6363b4c1748e9a70ed0515c2610df60d9600
parente1593c898f6c8951cba8fb5ce9da3aef9c249ce3
Bug 7688: (follow-up) rewrite t/db_dependant/Serials.t

A lot of tests were just a call to a funtion without any arguments,
whereas the function expect at least one argument.
These tests were kept, but all return values are now undef when a
mandatory argument is missing, so return values are consistent.

The part where subscription periodicity is changed could not work
because of ',' appended to each key in ModSubscription call. So it's
rewritten, taking into account the new API for subscription frequencies.
This script should leave your database intact because it revert any
modification made.

Also fix some warnings in C4::Serials and in C4::Items.
And fix a typo in koha-tmpl/.../subscription-numberpatterns.tt

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Work as described. No errors
Tested, again, without trouble.
With a suscription, tests successful.
No koha-qa errors

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Items.pm
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
t/db_dependent/Serials.t