]> git.koha-community.org Git - koha.git/commit
Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological...
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 6 Dec 2018 18:59:10 +0000 (15:59 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 11 Dec 2018 20:47:52 +0000 (20:47 +0000)
commitdbff938c7ff7eb277c6b94b56b5f03d3348f0017
tree795bf5d307937d05c291487f709f54e764d0ce2d
parentce160066a2b06742e348011324620c8e58b26f40
Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases

This patch makes outstanding_* methods be safe regarding pathological
account lines that get converted into another type because of the value
of amountoutstanding

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail because pathological account lines are wrongly
picked.
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=>SUCCESS: All green!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Account.pm