]> git.koha-community.org Git - koha.git/commit
Bug 35536: Reorder rollbacks
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 14 Dec 2023 07:54:22 +0000 (07:54 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 22 Mar 2024 11:26:40 +0000 (12:26 +0100)
commite32174f29ac1b06b60b160a0d37c6aaf767c9126
tree395f0bba3a5ec099c0800ab5f6848d253bbe83ab
parent9d73d40ea38ac7a1662f5058c22c57b2b7438e40
Bug 35536: Reorder rollbacks

Time to move all RemovePlugins calls BEFORE rollbacks.
Broken.t did not even include a transaction! Some modules
are removed there as well.

Test plan:
Search for wrong order with:
  grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins)
  No occurrences left? Think of another grep :)
Check number of records in plugin_data/methods.
Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
And check number of records again. Same?

Bonus: Apply TestMR plugin patch (marked DO NOT PUSH).
Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins".
Check plugin records in database.
Keep those records but remove last patch from git.
Run previous prove and verify no data changes since last check.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
t/db_dependent/Koha/Plugins/BackgroundJob.t
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
t/db_dependent/Koha/Plugins/Broken.t
t/db_dependent/Koha/Plugins/Circulation_hooks.t
t/db_dependent/Koha/Plugins/Patron.t
t/db_dependent/Koha/Plugins/authority_hooks.t