]> git.koha-community.org Git - koha.git/commit
Bug 17969: Refactor the way <<items.content>> is generated
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 19 Jan 2017 19:11:21 +0000 (20:11 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 30 Aug 2017 18:06:25 +0000 (15:06 -0300)
commite63eee05a09cc0373491cce213e012ffc011b9f3
treefc8e6fed64a22b5f3f7b6d7b18cd8b151473ad2d
parentbc09af634c92dc83f4eb28761bcff428481f6daf
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm
misc/cronjobs/advance_notices.pl
misc/cronjobs/overdue_notices.pl
t/db_dependent/Letters.t