]> git.koha-community.org Git - koha.git/commit
Bug 13669: (alternative) use DBIx::RunSQL
authorBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Wed, 18 May 2016 19:25:25 +0000 (16:25 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 23 May 2016 16:47:32 +0000 (16:47 +0000)
commite64f01ce0d6b3ff127a23070aa82427b69d89263
tree2e0b7bc3e2cf4559ac5bf534ff856027da732d6c
parent2358185379ed325eb388b717250e90978ffdea5a
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.7        66.5
58.6        66.0

b) SQL::SplitStatement (patch 1+2)
59.4        101
59.7        102

c) DBIx::RunSQL (patch 3)
60.7        66.8
59.4        66.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Installer.pm
installer/data/mysql/en/optional/marc21_holdings_coded_values.sql