]> git.koha-community.org Git - koha.git/commit
Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format
authorAndreas Roussos <arouss1980@gmail.com>
Thu, 27 Sep 2018 16:05:48 +0000 (19:05 +0300)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 9 Oct 2018 09:59:10 +0000 (09:59 +0000)
commitf12dabe6ccd9400a4ae744a5d74bbddcd9f7ac95
tree6e7d46df76d82d438b302327e13c3a4727778fa2
parentcc52094f208d78fd06d888975f4710de0886c7a7
Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip format

koha-create contains a call to `zcat` which fails if the file passed
as an argument is not in gzip format.

This patch fixes the issue by adding the -f flag to the zcat call in
koha-create, as per the top-voted answers in the following SE URLs:
https://unix.stackexchange.com/a/77309
https://unix.stackexchange.com/a/131944

Test plan:
1) in /etc/koha/koha-sites.conf, set the DEFAULTSQL variable to point
   to an _uncompressed_ SQL database dump
2) run `koha-create --create-db instance` and notice how it fails with:
   gzip: /path/to/dump.sql: not in gzip format
3) apply the patch
4) notice the extra line of information "The SQL file can be optionally
   compressed with gzip" in koha-sites.conf
5) run the `koha-create` command again, this time it should work
6) repeat with DEFAULTSQL pointing to a gzip'd dump, it should work too

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
debian/scripts/koha-create
debian/templates/koha-sites.conf