Changing text from Virtual Shelves to Lists

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online help for suggestions management

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to enable separate imageurls for item-level itypes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improving sample data for English

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating INSTALL and INSTALL.debian

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1319, can no longer delete an item with a waiting reserve on it

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1626, whitespace stripped from barcodes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1461, checkbox now doesnt display if you cant renew an item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1552, fix ordering of issued items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for item level itypes and toomany subroutine

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding README

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more re-arranging prior to release

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

re-naming some files prior to release

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing nomenclature on files in misc/, adding a few new utilities

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a new option, -w, which disables shadow indexing for the current batch (faster indexing of large sets where ACID isn't critical)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updates to some of the finer points of the install process on Etch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moving some files and deleting cataloguing/updateitem.pl, the _real_ updateitem.pl is in catalogue/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug with notforloan being checked properly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1253 borrowers names sorted case sensitivly in circulation.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1689

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Get biblioitem data in canbookbeissued, we need this for biblioitem level

itemtypes, to check for notforloan

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfixing Systempreferences:

    * fix to bug in version 3.00.00.038 update (bad SQL)
    * putting finesCalendar and CircControl in Circulation tab in
systempreferences
    * changing default for IndependantBranches to 0
    * removing ' from integers
    * fix canreservefromotherbranches nomenclature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Sysprefs Changes

* Fix for Bug 1601: uppercasesurnames system preference needs to be added

* Partial fix for Bug 1711: reinstate the ‘CircControl’ syspref, which is
of type Choice with the following choices: PickupLibrary | PatronLibrary |
ItemHomeLibrary

* reinstate the ‘finesCalendar’ syspref, which is of type Choice with
the following choices: ignoreCalendar | noFinesWhenClosed

* ‘HomeorHoldingbranch’ is deprecated and removed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authority zebra config: include gils.att

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 authorities: fixed LDR/06 = 'a'

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: make tag editor links consistent with bib

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 authorities: fixed 008 value builder

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 bibs: fixed mistake in leader value builder

Leader/05 = 'a' does *not* always mean a monograph

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 authorities: fixed leader value builder

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cataloging plugins: enable access from authorities

Allow plugins to be be launched from authorities
editor as well as bib editor, without duplicating
plugin_launcher.pl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

OPAC VirtualShelves overhaul -- bugfix 1413 (among others)

Making shelves work in the opac.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix fatal error on authority search when biblioaddauthority syspref is set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added logdir to koha-conf.xml

This parameter, initialized from LOG_DIR during installation,
allows scripts to specify a common directory for logs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC and ISBD display: removed references to action-catalogue.inc

This include no longer exists.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed Javascript in additem.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

only munge copyrightdate and publicationyear if they exist

Prior to this fix, those two keys were always
created by TransformMarcToKoha even when
not appropriate (e.g., for items).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed quoting problem in updatedatabase.pl; version now 038

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing dialog formatting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Style improvements to moredetail.tmpl; Bug fix for removal of virtual shelf items in opac.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Beginning some reformatting of advanced search interface

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor reformatting of error messages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to enable reading history in the staff client.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

missing "

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Search.pm Bugfixing

Getting Search.pm air tight ... cleaned up some local variables
that were declared global

fix to asynchronous federated searching lost since dev_week, immediate
use is authority search

template fixes to item-level itemtypes and bib-level itemtypes

temp workaround to javascript problems preventing item edits

fix to installer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improve embedded documentation and perldoc

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/holded by/maintained/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improvements to nomenclature re: authority tag, making .tip global

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

important: DBD::mysql 4.004 or later required

This version of DBD::mysql is required in order to have
proper handling of UTF8 strings.

Also bumped version of YAML::Syck down to 0.71 to
match Debian stable package.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1582, if independent branches is on, you cant return to

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo in new borrower column

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

session management: use YAML::Syck for serialization

When using mysql and a sufficiently recent version
of DBD::mysql that actually respects the mysql_enable_utf8
option, setting the current branch to a name that
includes a diacritic causes the session to fail
and forces the user to the login screen upon
clicking another link.

This turned out to be due to the default (Data::Dumper)
serialization used by CGI::Session, which truncated the
session object at the diacritic.  By enabling
that module's YAML serialization option, the problem
was resolved.

This patch introduces a dependency on the YAML::Syck
module.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

UTF8 and mysql: enable UTF8 mode correctly

Doc for DBD::mysql states that if not setting
mysql_enable_utf8 as part of the database
connect(), must do it before doing "set names utf8"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding change to syspref for finesmode.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding 'exempt fine on return' option.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cleanup in memberentry,categories.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

revert to sql in updateitem.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1704, now if autoitemreturns is off you get a dialogue warning a

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Getting rid of noisy warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Taking out warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1666

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Input.pm - perldoc correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

about.pl -- get apacheVersion for etch-like setups

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1164, child branch not defaulting to guarantor's on add child

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improving visual display of sysprefs, re-organizing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1654

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1014, internal server error on unknown borrower

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

web installer: clean up warns; improve naming of Nozebra op

The former 'Nozebra' op has been renamed to 'SetIndexingEngine'
to avoid having a 'Nozebra' op and a 'NoZebra' parameter
distinguished only by case.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BIG COMMIT: minimal fix to authorities search

This is a minimal fix -- pname authorities work propertly, but nothing
else has been tested yet

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Big bugfix for bug 1631

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1699, cant change category type

Now you can change a borrower to any category

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

category template fix for bug 1699

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1686, moremember.pl doesnt know if a borrower is a child

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1691

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for typo in Insert line in updatedatabase.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding OPACItemsResultsDisplay syspref & bumping to version 036

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing some code that is for staff, not for opac

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

replacing SHELF_LOC by LOC, as decided with kados on the chat

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to handle notforloan authorised values (we now handle wthdrawn, itemlost, damaged AND notforloan fields)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

mapping items.onloan to 995$n (to handle biblio status from zebra)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix typo: "Ok" => "OK"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed unmatched /TMPL_IFs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

prefixing all holdings auth values with HINGS

modrequest.pl did not previously have auth checking, security bug!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing unused ReadingHistory syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1696: Reading record page fails

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing postgres sql from main installaer dir, it exists in data/Pg/, though in a different form, Chris, please double-check that I haven't removed the latest one and if so, git revert and git mv it into the right slot.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to bug 1569

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

WARNING: BIGFIXING 670

670 is primarily about the status of a biblio or item that's got a
hold on it ... specifically the 'in transit' and 'waiting' status.
It applies to the following pages.

* request.pl - tested
* detail.pl - tested
* circulation.pl - tested
* moremember.pl - tested
* opac-user.pl - doesn't show transit status, but only shows waiting
when item has arrived at the pickup library
* opac-detail.pl - doesn't show hold statuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1368 - remove FOREIGN_KEY_CHECKS = 0 from installer

[1] Web installer no longer sets FOREIGN_KEY_CHECKS = 0
    when loading frameworks and sample SQL.
[2] Removed FOREIGN_KEY_CHECKS = 0 from SQL scripts
[3] Fixed FK issues in en/optional/sample_patrons.sql

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo in directory name

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updating README.debian

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT - replaced TransformMarcToKoha

Replaced with FasterTransformMarcToKoha
from a previous commit.  Main differences are:

[1] At least twice as fast because of improvement
    in algorithm for processing the MARC record --
    each tag is processed only once.
[2] Fixed bug where biblio.notes would end up with
    an extra ' | ' at the end.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulkmarcimport: enable MARC-8 to UTF-8 conversion

Enabled automatic conversion of MARC-8 records to
UTF-8.  Record is converted if its Leader/09 contains
a blank and the -s (skip) option hasn't been supplied
on the command-line.  Any record that cannot be converted
to UTF-8 is skipped.

Also now use Unicode Normalization Form C (NFC) for
records converted from MARC-8.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed C4::Dates usage that caused crash of orderreceive.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extraneous comments

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improved error detection in AddBiblioAndItems

Introduced new C4::Biblio function CheckItemPreSave,
which checks for duplicate barcodes and invalid
branch codes.  Not yet sure whether this function
needs to be exported or whether it will just be
used internally to C4::Bibli.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed error message when branch cannot be saved

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed superfluous comments

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Biblio::AddBiblioAndItems - added duplicate barcode check

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulk MARC record import - speed improved

Changes to improve speed of MARC bib and item
imports:

[1] Turn off autocommit and commit database
    transactions in larger batches.
[2] Introduce a new C4::Biblio function (AddBiblioAndItems)
    to combine AddBiblio and AddItems -- this is faster
    because we are not parsing the MARC XML of the biblio
    every time we add an item.
[3] Introduce FasterTransformMarcToKoha, which is much
    faster than TransformMarcToKoha.  The new version,
    which will replace the old one once it has been
    fully tested, scans through each field in the
    MARC record just once, instead of potentially
    dozens of times.
[4] Remove code in bulkmarcexport that moved the
    item tags to separate MARC::Record objects.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>