]> git.koha-community.org Git - koha.git/log
koha.git
8 years agoBug 14542: Transliterate rule for all single quote forms
Fridolin Somers [Thu, 16 Jul 2015 15:48:14 +0000 (17:48 +0200)]
Bug 14542: Transliterate rule for all single quote forms

Single quotes in common language (not in programming) are usually ', but
there is also the form known as ’ in HTML.  See
https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29

This bug proposes to transliterate all forms into a space.

Test plan :
(I'll use the code ’ instead of the unicode character)
- Without the patch
- Create a record with title : L’avion d’argile
- Index this record
- Search for "L’avion d’argile" => You find the record
- Search for "L'avion d'argile" => You do not find the record
- Apply patch
- Search for "L’avion d’argile" => You find the record
- Search for "L'avion d'argile" => You find the record
- Search for "L avion d argile" => You find the record

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14544: Fix regression on sending an email from staff
Jonathan Druart [Fri, 13 Nov 2015 16:49:53 +0000 (16:49 +0000)]
Bug 14544: Fix regression on sending an email from staff

The shelfnumber was not filled and result in a software error
Can't call method "get_contents" on an undefined value at
/home/koha/src/virtualshelves/sendshelf.pl line 74.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Whith patch mail is sent.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15116: Show menu at the top of batch circ page
Martin Stenberg [Thu, 5 Nov 2015 12:58:55 +0000 (13:58 +0100)]
Bug 15116: Show menu at the top of batch circ page

This patch adds the user interaction menu to the top of the batch
checkout page.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14078: (followup) converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:35:00 +0000 (12:35 +0200)]
Bug 14078: (followup) converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch adds missing conversions.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14078: converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:24:23 +0000 (12:24 +0200)]
Bug 14078: converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch changes some odd actual conversions.

In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater :
  ($char >= 0xC0 && $char <= 0xDF)
So conversion like "$chars{0x81d1}=0x00b0" will never be used.
Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15154: Allow correct translation for upload local cover image
Hector Castro [Sat, 7 Nov 2015 06:16:02 +0000 (00:16 -0600)]
Bug 15154: Allow correct translation for upload local cover image

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the phrase "Please upload one"
-Apply the patch and reload the page.
-New phrase appear "Select the image file to upload" with button Upload
-Update translation files : cd misc/translator; perl translate update es-ES
-You will see in es-ES-staff-prog.po the new entry
"Select the image file to upload. %sUpload%s"
-You can see the result installing the translation
cd misc/translator ; perl translate install es-ES

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  A native English speaker could confirm that the wording is ok: Please select
  the image file to upload

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15137: Display ISBN and author info when sending list by email
Jonathan Druart [Fri, 13 Nov 2015 15:18:56 +0000 (15:18 +0000)]
Bug 15137: Display ISBN and author info when sending list by email

Disclaimer: this is not caused by bug 14544 :)
And can be backported!

Both isbn and author information are missing when a list is sent by
email.
Emails sent from OPAC and staff should be (almost) the same.

Test plan:
1/ Sent a list by email (Button "Send list")
2/ The email you will receive should contain the isbn and author info

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of last patch of Bug 14544
Works ok, mail with authors and ISBN
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 6657: Prevent biblionumber to be duplicated
Jonathan Druart [Thu, 17 Sep 2015 13:31:55 +0000 (14:31 +0100)]
Bug 6657: Prevent biblionumber to be duplicated

If the biblionumber field is displayed in the framework, on editing a
biblio the field/subfield will be duplicated.
To prevent that this patch adds a check when building the field list.

Test plan:
1/ map biblio.biblionumber with 999$c
2/ Display 999$c in a framework
3/ Edit a biblio using this framework
4/ Save => The field should not have been duplicated

5/ map biblio.biblionumber with 001
6/ Display 001 in a framework
7/ Edit a biblio using this framework
8/ Save => The field should not have been duplicated

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described, aldo removes duplicate values.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14795: Prevent modifying a record without using the original framework
Jonathan Druart [Fri, 13 Nov 2015 16:30:32 +0000 (16:30 +0000)]
Bug 14795: Prevent modifying a record without using the original framework

The origin framework is not passed on modifying the records and so the
default one is used.
This can caused data lost.

Test plan:
- Create a bibliographic record and specify a framework (not the default
one).
- Use the Batch records modification tools to modify it.
=> Without this patch, the default framework (framework code "") is used
and can deteriorate the record
=> With this patch, the record is saved using the original framework

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested framework is lost using tool without patch
Problem gone with patch
No qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15181: Rename marc21 fast add framework sql file
Bernardo Gonzalez Kriegel [Thu, 12 Nov 2015 16:43:33 +0000 (13:43 -0300)]
Bug 15181: Rename marc21 fast add framework sql file

This patch simply renames fast add sql file in order
to load this file before default framework.

To test:
1) Do a marc21 install (de,en,es,it)
load all sample files
check Fast Add framework is empty (no fields/subfields)

2) Apply the patch

3) Do an install again, this time FastAdd must have values.

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15058: Update German web installer sample files for 3.22
Katrin Fischer [Wed, 11 Nov 2015 23:45:04 +0000 (00:45 +0100)]
Bug 15058: Update German web installer sample files for 3.22

- Completes translations in German web installer sample files.
- Adds AddressFormat = German to the default system preference
  settings.

To test:
- Run the web installer in German with all sample files selected
- Confirm no error messages are shown
- Bonus: if you speak German, check spelling and translations

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15178: Update of Italian web installer .sql files for 3.22
Zeno Tajoli [Thu, 12 Nov 2015 11:57:05 +0000 (12:57 +0100)]
Bug 15178: Update of Italian web installer .sql files for 3.22

- iNot worked on notices.sql becouse there is a bug on it (Bz 15177)
- Some change in Italian default system preference settings.

To test:
- Run the web installer in Italian with all sample files selected
- Confirm no error messages are shown

http://bugs.koha-community.org/show_bug.cgi?id=15178

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Proofreading OK. Web installer OK. Tutto bene, grazie

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15079: Batch Delete Records Error
Kyle M Hall [Thu, 29 Oct 2015 11:48:02 +0000 (07:48 -0400)]
Bug 15079: Batch Delete Records Error

When using the batch deletion tool, if the script attempts to delete an
undeletable item, the script will die with the error:

Label not found for "next BIBLIONUMBER" at
/usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172.

Test Plan:
1) Attempt to batch delete a record with an item that cannot be deleted
2) Note error
3) Apply this patch
4) Repeat step 1
5) Note the error no longer occurs

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Follow comment 5 to reproduce the issue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have not tested this patch, but looking at the code it is obviously a mistake.
If an error occured, we rollback and skip this record.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: dbms expects a iso formatted date
Jonathan Druart [Wed, 11 Nov 2015 14:26:51 +0000 (14:26 +0000)]
Bug 14985: dbms expects a iso formatted date

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Simplify the date management in AddReserve
Jonathan Druart [Wed, 11 Nov 2015 12:07:05 +0000 (12:07 +0000)]
Bug 14985: Simplify the date management in AddReserve

The code is much more readable using the str param of output_pref

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Fix regression on patron search
Jonathan Druart [Wed, 11 Nov 2015 12:03:51 +0000 (12:03 +0000)]
Bug 14985: Fix regression on patron search

This patch fixes 2 major errors introduced by last patch:
1/ Undefined subroutine &C4::Utils::DataTables::Members::dt_from_string
called
when searching for patrons
2/ Display the dates on the patron search in the pref format, not iso

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Remove C4::Dates from files in folder C4/*.pm (part one)
Marc Véron [Thu, 8 Oct 2015 21:02:30 +0000 (23:02 +0200)]
Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one)

This patch removes C4::Dates from following files in folder C4:

- C4/Members.pm
- C4/Reserves.pm
- C4/Search.pm
- C4/Utils/DataTables.pm
- C4/Utils/DataTables/Members.pm
- C4/VirtualShelves/Page.pm

To test:
 -run tests as appropriate,
- have a close look at the code changes
- try to find regressions

http://bugs.koha-community.org/show_bug.cgi?id=14985

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Bug 14985: (followup) Remove eval if dates come from database

This patch removes some evals from date-formatting where the dates come
from the database.

See comments #7 - #9

Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete).

Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm

Ths patch removes a stray C4::Dates from C4/Overdues.pm

- To test got to a patron who has overdues
  (Home > Circulation > Checkouts > [Patron])
- Print overdues

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15166: Carp if an invalid date is passed
Jonathan Druart [Wed, 11 Nov 2015 11:55:05 +0000 (11:55 +0000)]
Bug 15166: Carp if an invalid date is passed

Sign-off on second patch.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15166: Make output_pref takes a string in parameter
Jonathan Druart [Tue, 10 Nov 2015 16:38:51 +0000 (16:38 +0000)]
Bug 15166: Make output_pref takes a string in parameter

To simplify the management of dates, it would be great that output_pref takes a string in parameter.

  my $date = $input->param('my_date');
  $date = eval { dt_from_string( $date ) } if $date;
  $date = output_pref({dt => $date}) if $date;

Could be replace with:

  my $date = output_pref({ str => $input->param('my_date') });

Tested with t/DateUtils.t, passed OK.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14915: (follow-up) [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o
Jonathan Druart [Fri, 13 Nov 2015 14:16:04 +0000 (14:16 +0000)]
Bug 14915: (follow-up) [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o

Reported on bug 15186.

Test plan:
Do a search on the staff interface
You will get an error in the console and the image + checkboxes are not
display.

With this patch it will be fixed.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoKoha 3.22 beta v3.22.00-beta
Tomas Cohen Arazi [Thu, 12 Nov 2015 13:08:51 +0000 (10:08 -0300)]
Koha 3.22 beta

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoPreliminary (beta) release notes for 3.22
Tomas Cohen Arazi [Thu, 12 Nov 2015 13:05:50 +0000 (10:05 -0300)]
Preliminary (beta) release notes for 3.22

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: Add missing coma in ru-RU
Jonathan Druart [Thu, 12 Nov 2015 12:55:08 +0000 (12:55 +0000)]
Bug 15177: Add missing coma in ru-RU

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: TO_PROCESS notice for fr-FR
Frédéric Demians [Thu, 12 Nov 2015 06:46:58 +0000 (07:46 +0100)]
Bug 15177: TO_PROCESS notice for fr-FR

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: Sample notice TO_PROCESS confuses budget and fund
Katrin Fischer [Wed, 11 Nov 2015 23:22:00 +0000 (00:22 +0100)]
Bug 15177: Sample notice TO_PROCESS confuses budget and fund

Changes budget to fund in all TO_PROCESS notices but the
German sample file.

The German sample file will be dealt with in a separate patch.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoTranslation updates for Koha 3.22.0-beta release
Bernardo Gonzalez Kriegel [Tue, 10 Nov 2015 18:25:58 +0000 (15:25 -0300)]
Translation updates for Koha 3.22.0-beta release

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7143: Add Marc Veron to the release team
Tomas Cohen Arazi [Wed, 11 Nov 2015 22:00:48 +0000 (19:00 -0300)]
Bug 7143: Add Marc Veron to the release team

During this release cycle he worked really hard looking for things to fix.
He's a brave bug wrangler and his name should be on the credits for 3.22.
Period.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Well deserved.

8 years agoBug 13799: (PM followup) Dependency updates
Robin Sheat [Wed, 11 Nov 2015 03:26:42 +0000 (16:26 +1300)]
Bug 13799: (PM followup) Dependency updates

Added new rependencies.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15102: Fix capitalization for some strings on XSLT detail pages
Hector Castro [Sun, 8 Nov 2015 05:59:23 +0000 (23:59 -0600)]
Bug 15102: Fix capitalization for some strings on XSLT detail pages

To test:
-Search records with 336, 337, 338, 700$i, and 7XXind=2
-Search records with 508, 264Ind=4, 246, 856, and LDR/6 and
LDR/7 (BK, VM, CR, CF)
-Notice the capitalization (Contained Works, Related Works, Media Type,
Content Type, and Carrier Type, Production Credits, Copyright Date,
Other Title, Online Access, Continuing Resource, Mixed Materials,
Computer File, Visual Material) in both OPAC and Intranet for
records detail pages and results pages
-Apply this patch
-Search again and get notice about the capitalization following
Koha coding guidelines

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14553: Silencing warn triggered when clearing item rating on OPAC
Aleisha [Tue, 21 Jul 2015 18:38:58 +0000 (18:38 +0000)]
Bug 14553: Silencing warn triggered when clearing item rating on OPAC

To test:

1) Go to any item and clear the star rating (don't have to set a rating first)
2) Notice the warn
3) Apply patch and reload page
4) Clear star rating
5) Notice no warn
6) Click a star to add a rating
7) Make sure your rating, the average rating and amount of votes are all
   correct
8) Could be beneficial to log in as another user and try to add a rating on the
   same item from their account. Check the average rating is
   cacalculated and amount of votes increases
9) Confirm still no warns

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Can see the warning in logs, and its disappearance with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14998: Restore previous behavior
Jonathan Druart [Wed, 11 Nov 2015 12:40:52 +0000 (12:40 +0000)]
Bug 14998: Restore previous behavior

We want to convert a us or metric date formatted to the format defined in
the pref.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14998: Remove C4::Dates from installer and maintenance folders
Marc Véron [Sat, 10 Oct 2015 09:38:20 +0000 (11:38 +0200)]
Bug 14998: Remove C4::Dates from installer and maintenance folders

- installer/data/mysql/updatedatabase.pl
- misc/maintenance/fix_accountlines_date.pl

To test for updatedatabase.pl

- perl installer/data/mysql/updatedatabase.pl
- review code. Difficult to test, because the code affects
  $DBversion = '3.03.00.035'

To test for misc/maintenance/fix_accountlines_date.pl
 - review code
 - The file seems to be a file used for an update, could it be obsolete?
   If yes, remove it in a follow-up

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Code OK. Tested updatedatabase.pl with an old DB backup: OK.
  fix_accountlines_date.pl still working after the patch. Could be removed from
  master IMO.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14544: Remove debug line
Jonathan Druart [Wed, 11 Nov 2015 13:19:22 +0000 (13:19 +0000)]
Bug 14544: Remove debug line

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015)
Katrin Fischer [Sun, 1 Nov 2015 14:43:42 +0000 (15:43 +0100)]
Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015)

Updates the framework files using the po file based mechamism
provided by Bernardo.

To test:
- Check that changes make sense
- Run the Koha web installer for de-DE
- Confirm all 4 files changed here load without errors

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All files load without errors, pass marc bibliographic fw test
No errors
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14735: Save cache_expiry on modifying a report
Jonathan Druart [Tue, 10 Nov 2015 15:17:12 +0000 (15:17 +0000)]
Bug 14735: Save cache_expiry on modifying a report

The cache_expiry is not saved when updating a SQL report.

Test plan:
0/ Enable memcached
1/ Create a sql report
2/ Edit it and change the cache expiry value
3/ Edit again
=> The value should have been updated.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Repeatable bug. Solved with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7895: Test for PSGI-related env to report in about.pl
Tomas Cohen Arazi [Wed, 21 Oct 2015 01:50:47 +0000 (22:50 -0300)]
Bug 7895: Test for PSGI-related env to report in about.pl

This patch introduces a test for psgi/plack in %ENV and uses that data
to report in the about page.

To test:
- On current master (without Plack), go to about.pl
- Notice no mention of Plack
- Apply the patch
- Reload the about page
=> SUCCESS: No change
- Enable plack, and access the about page through Plack
=> SUCCESS: There is a PSGI label, showing that you are running Plack
- Sign off :-D

Regards

PS: I haven't tested the mod_perl scenario, I just grabbed the MOD_PERL env var
from the docs.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15011: koha-indexer should define the --pidfiles on starting the daemon
Jonathan Druart [Wed, 14 Oct 2015 13:20:38 +0000 (13:20 +0000)]
Bug 15011: koha-indexer should define the --pidfiles on starting the daemon

The --pidfiles options is not provided on starting the daemon and the is_indexer_running consider that the daemon is not running

Test plan:
koha-indexer start
koha-indexer stop

should start and stop the zebra daemon wuthout any error.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tested on kohadevbox:ansible

sudo debian/scripts/koha-indexer --stop kohadev
sudo debian/scripts/koha-indexer --start kohadev
sudo debian/scripts/koha-indexer --restart kohadev

All work as expected on the different scenarios.

8 years agoBug 7143: Updates for the 3.22 release
Tomas Cohen Arazi [Tue, 10 Nov 2015 13:51:16 +0000 (10:51 -0300)]
Bug 7143: Updates for the 3.22 release

This patch adds the new devs missing from the history.txt file
that contributed patches during the 3.22 release cycle. It fixes
the missing ones on the about page too.

Bonus: Adds Olli, who was missing, so numbering shift was needed too.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: Fix typo in opac-basket.tt
Jonathan Druart [Tue, 10 Nov 2015 09:06:32 +0000 (09:06 +0000)]
Bug 14575: Fix typo in opac-basket.tt

No more typo in the codebase.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow
Jonathan Druart [Mon, 9 Nov 2015 11:01:02 +0000 (11:01 +0000)]
Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: OPACURLOpenInNewWindow should apply to item-level urls too
David Cook [Tue, 21 Jul 2015 03:09:39 +0000 (13:09 +1000)]
Bug 14575: OPACURLOpenInNewWindow should apply to item-level urls too

This patch applies the OPACURLOpenInNewWindow system preference
to item-level urls (in addition to the pre-existing bib-level url
handling).

_TEST PLAN_

Before applying:

1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
2) Note that the current tab changes to that url
3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
4) Note that the current tab changes to that url

Apply the patch.

After applying:

5) Click on an item-level url
6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
should be set to "do")
7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
url
8) Note that the url opens in the current tab

9) Repeat the above steps 5-8 alternating
"TrackClicks" between "Don't track" and either "Track" or
"Track anonymously".

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14743: addorder.pl redirect problems under plack behind apache 2.4.10
Kyle M Hall [Thu, 5 Nov 2015 13:24:51 +0000 (13:24 +0000)]
Bug 14743: addorder.pl redirect problems under plack behind apache 2.4.10

I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump):

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:28:41 GMT
Server: Apache/2.4.10 (Debian)
Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610
Vary: User-Agent
Content-Length: 0
Keep-Alive: timeout=5, max=98
Connection: Keep-Alive
Content-Type: text/x-perl

However, when running behind apache 2.4.10 on Debian wheezy I see chunked response:

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:21:28 GMT
Server: Apache/2.4.10 (Debian)
Vary: User-Agent
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/x-perl

60
Transfer-Encoding: chunked
Date: Thu, 27 Aug 2015 13:21:28 GMT
Connection: keep-alive

0

0

This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen).

In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error!

Test Plan:
1) Using plack, add an order to a basket from an external source
2) Note the error
3) Apply this patch
4) Add an order to a basket from an external source
5) Note you get no error!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15160: GetTopIssues.t should create random data
Tomas Cohen Arazi [Mon, 9 Nov 2015 14:35:03 +0000 (11:35 -0300)]
Bug 15160: GetTopIssues.t should create random data

This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it
creates its own data with random values. It does so by replacing (legacy)
SQL inserts and fixed value data inserting by TestBuilder generated data.

There is no expected behaviour change.

To test:
- Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype
  > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST');
- Run:
  $ prove t/db_dependent/Circulation/GetTopIssues.t
=> FAIL: The insert line fails
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation/GetTopIssues.t
=> SUCCESS: tests pass due to random data usage.
- Sign off

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Test plan produces the expected result, failing, then OK.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15036: Do not overwrite complete status in basket ops
Colin Campbell [Tue, 20 Oct 2015 13:19:35 +0000 (14:19 +0100)]
Bug 15036: Do not overwrite complete status in basket ops

Reopening or closing a basket should preserve the completed
status for receipted orders.

This patch excludes orderlines with the completed status
from having their status rewritten as a result of the
change in basket status

Made the subroutines involved more efficient by removing an
unnecessary loop and by not fetching a large amount of
superfluous data

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: DBRev 3.21.00.054
Tomas Cohen Arazi [Mon, 9 Nov 2015 18:13:03 +0000 (15:13 -0300)]
Bug 8064: DBRev 3.21.00.054

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Fix unit tests for createMergeHash
Julian Maurice [Mon, 9 Jun 2014 07:55:28 +0000 (09:55 +0200)]
Bug 8064: Fix unit tests for createMergeHash

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Little fix for 003, 005, 008 in MARC21
Stefano Bargioni [Tue, 11 Mar 2014 09:22:12 +0000 (10:22 +0100)]
Bug 8064: Little fix for 003, 005, 008 in MARC21

I found a little bug in the patch. Subfield '@' of tags 003, 005, 008 in
MARC21 were not correctly handled by function check_mandatory() in
merge.tt. I fixed the problem. In my opinion, the patch can be signed
off.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Fix issues with control fields and non-repeatable check
Julian Maurice [Fri, 20 Dec 2013 10:01:09 +0000 (11:01 +0100)]
Bug 8064: Fix issues with control fields and non-repeatable check

Fields < 010 were systematically unchecked during target rebuild because
they have no subfields (unchecking manually all subfields of a field
automatically uncheck the field)
When user check a field or a subfield, we have to uncheck it before
calling (sub)field_can_be_added. Otherwise, field is treated as if it
was already in target record, and this is a problem for non-repeatable
fields.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Change the way target record is built.
Julian Maurice [Wed, 6 Nov 2013 11:17:45 +0000 (12:17 +0100)]
Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Merge several biblios
Julian Maurice [Tue, 28 May 2013 14:24:53 +0000 (16:24 +0200)]
Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
    of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
    delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
    biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: (QA followup) Add notes to usage text about --fees
Kyle M Hall [Tue, 15 Sep 2015 12:28:45 +0000 (08:28 -0400)]
Bug 14402: (QA followup) Add notes to usage text about --fees

Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.
Barton Chittenden [Thu, 10 Sep 2015 22:03:43 +0000 (22:03 +0000)]
Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl
Barton Chittenden [Sat, 18 Jul 2015 20:29:29 +0000 (13:29 -0700)]
Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add unit tests for purge_zero_balance_fees()
Barton Chittenden [Sat, 18 Jul 2015 19:58:51 +0000 (12:58 -0700)]
Bug 14402: Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
    * accountlines.amountoutstanding is 0, and date is set to $days - 1
      days ago. The accountlines row should not be deleted.
    * accountlines.amountoutstanding is 0, and date is set to $days
      days ago.  the accountlines row should not be deleted, because
      the difference must be *greater* than $days.
    * accountlines.amountoutstanding is 0, and date is set to $days + 1
      days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm
Barton Chittenden [Sat, 18 Jul 2015 18:41:38 +0000 (11:41 -0700)]
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7369: Duplicate item and add dropdown buttons for item actions
Nick Clemens [Sat, 21 Mar 2015 16:27:04 +0000 (12:27 -0400)]
Bug 7369: Duplicate item and add dropdown buttons for item actions

This patch adds a link to duplicate existing items on the edit items screen

To test:
1 - Apply patch
2 - navigate to the edit items screen for a record with existing items
3 - click the duplicate link and ensure item info but not barcode are carried over
4 - save the item and ensure it is added correctly
5 - check that all previous functionality on page works as before

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t
Julian Maurice [Mon, 9 Nov 2015 13:41:00 +0000 (14:41 +0100)]
Bug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t

create_biblio was returning biblioitemnumber instead of biblionumber.
This can cause problems when biblionumber and biblioitemnumber are not
the same.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14867: userid not generated when defined in BorrowerUnwantedField
Fridolin Somers [Tue, 22 Sep 2015 07:49:39 +0000 (09:49 +0200)]
Bug 14867: userid not generated when defined in BorrowerUnwantedField

When userid is not provided when creating a new patron, it is generated
using surname and firstname.  The bug is when userid is defined in
syspref BorrowerUnwantedField, the input text is missing in patron
creation form. When saving you always get an alert message :
"Username/password already exists". No patron can be created.

This patch corrects by adding this case to userid generation conditions.

Test plan :
- add 'userid' in syspref BorrowerUnwantedField
- try to create a new patron : /cgi-bin/koha/members/memberentry.pl
- there is not input text for userid
- choose non-existing surname and firstname
- click on save
  => Without patch : patron is not created, you see the alert message
     "Username/password already exists"
  => With patch : patron is created, userid is generated with surname
     and firstname
- remove 'userid' in syspref BorrowerUnwantedField and check it can be
  defined in patron creation form

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  The issue is there, and this patch fixes it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14388: Funds should be sorted by budget_code
Jonathan Druart [Thu, 2 Jul 2015 15:42:16 +0000 (16:42 +0100)]
Bug 14388: Funds should be sorted by budget_code

Before this patch, the funds were sorted by budget_id, which does not
make any sense.

This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and
admin/aqbudgets.pl)

Test plan:
On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that
the funds are now sorted by fund code (DB column budget_code)

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14687: Patron's transaction history changes items' order after paying fines.
Joonas Kylmälä [Mon, 17 Aug 2015 12:40:05 +0000 (12:40 +0000)]
Bug 14687: Patron's transaction history changes items' order after paying fines.

Sorts Patron's accounting data consistently from newest to oldest.
It doesn't depend on anymore to timestamp (which can be same for multiple
entries) from database but instead uses accountline's id to sort.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 12540: Display "Every" on editing a MMT action if previously selected
Jonathan Druart [Tue, 22 Sep 2015 10:16:28 +0000 (11:16 +0100)]
Bug 12540: Display "Every" on editing a MMT action if previously selected

On creating a marc modification template action, the "All" is changed with
"Every" if the condition field is the same as the original field.

But on editing, the "All" value is not replaced. For consistency, it
should.

Test plan:
1/ Create the following action:
    Copy field 650$x to 650$y if 650$z matches "foobar"
Note that the "All" is replaced with "Every" when the condition is the
same field as the original field.
2/ Save
3/ Edit the action.
The "Every" should be selected.

Without this patch, "All" is selected.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15151: Avoid DB access to load C4::Members
Tomas Cohen Arazi [Fri, 6 Nov 2015 14:21:56 +0000 (11:21 -0300)]
Bug 15151: Avoid DB access to load C4::Members

In order to avoid loading Koha::NorwegianPatronDB a DB query was
used. Instead, a require should be used. This causes non-db_dependent
tests that load C4::Members to fail.

To test:
- Shut mysql down
  $ sudo service mysql stop
- Run the tests:
  prove t/Circulation_barcodedecode.t
=> FAIL: DB connection is expected, tests fail
- Apply the patch
- Run the tests:
  prove t/Circulation_barcodedecode.t
=> SUCCESS: Tests pass
- Sign off .-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14878: (QA followup) Remove useless diag
Tomas Cohen Arazi [Fri, 6 Nov 2015 17:42:28 +0000 (14:42 -0300)]
Bug 14878: (QA followup) Remove useless diag

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14878: Tests - Create the branchcodes when needed
Jonathan Druart [Tue, 22 Sep 2015 16:34:16 +0000 (17:34 +0100)]
Bug 14878: Tests - Create the branchcodes when needed

Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB.
If they need them, they should create them.

Test plan:
Execute the differente test files on a DB without any branchcode or
at least without CPL/MPL branches.
Confirm that the tests pass.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14202: Unexpected parameter for window.open in marc21_linking_section.pl
Marcel de Rooy [Tue, 14 Jul 2015 19:57:10 +0000 (21:57 +0200)]
Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl

The builder of this plugin includes a window.open call with the name
parameter: \"marc21_field_7\"+ event.data.id +\"\"
Note that this is not the name of the new window.
This trivial patch adjusts this unusual name by tag_editor like other
plugins.

Test plan:
Attach marc21_linking_section to 773$9.
Click on the Tag editor button.
If it opens, it still works :)
Note that the name of the popup is still:
    Koha > Cataloguing > plugin for links

Signed-off-by: Fredreic Demians <f.demians@tamil.fr>
  Plugin still working, with a valid pop-pup window id.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 11431: (QA followup) remove diags
Tomas Cohen Arazi [Fri, 6 Nov 2015 18:08:37 +0000 (15:08 -0300)]
Bug 11431: (QA followup) remove diags

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15146: Format date of birth on patrons requesting modification page
Marc Véron [Fri, 6 Nov 2015 07:50:20 +0000 (08:50 +0100)]
Bug 15146: Format date of birth on patrons requesting modification page

To reproduce / test

- Log in to Opac
- Go to "your personal details"
- Request a change of the date of birth
- Log in to Staff client
- Follow link to Patrons requesting modifications
  (/koha/members/members-update.pl)
=> The date is not formatted in syspref format

- Apply patch, reload members-update.pl
=> The date is formatted in syspref format

- Approve changes
- Verify that changes are saved

This is independent from C4::Dates removal.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Changes saved Ok, Update patron record follows
dateformat syspref

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14956: (followup) Fix birthday date validation in Opac
Marc Véron [Thu, 5 Nov 2015 13:49:23 +0000 (14:49 +0100)]
Bug 14956: (followup) Fix birthday date validation in Opac

To reproduce / test:

- In Opac: Go to 'your personal details'
- Enter a valid birtday date
- In Staff client: Go to Home > Patrons > Update patron records
  (Link on start page: Patrons requesting modification)
- Verify that the birtday date is correct
- Back in Opac, clear the birthday date, try to submit
  => Validation message appears
- Enter an invalid date (32/32/2999 or 00/00/0000), try to submit
  => Birthday date field is cleared, validation message appears.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Wrong today corrected

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14956: C4::Dates from files opac/*.pl
Marc Véron [Mon, 5 Oct 2015 12:38:08 +0000 (14:38 +0200)]
Bug 14956: C4::Dates from files opac/*.pl

Remove C4::Dates from files:
-  opac/opac-memberentry.pl
-  opac/opac-reserve.pl
-  opac/opac-search-history.pl
-  opac/opac-showreviews.pl
-  opac/opac-suggestions.pl
-  opac/opac-serial-issues.pl
-  opac/opac-alert-subscribe.pl
-  opac/opac-ics.pl

To test:
- Apply patch
- Verify, that self registration and holds work as before
- Verify that tabs in catalog item detail work and display
  as before
- For serials: Verify that subscriptions work as before. It is a
  little bit hidden, in tab Subscriptions, then 'More details', then
  tab 'Brief history', button 'Subscribe to email notificatin on
  new issues'
- For ics: Can not be tested at the moment, not yet used (Bug 5456),
  pls. have a look at the code changes

(Amended following comment #2)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15150: Make t/ tests skip if Test::DBIx::Class absent
Tomas Cohen Arazi [Fri, 6 Nov 2015 13:29:21 +0000 (10:29 -0300)]
Bug 15150: Make t/ tests skip if Test::DBIx::Class absent

Tests in t/ should always pass for building the Debian packages
for Koha. But we've started using Test::DBIx::Class for writing
mocked tests, and that lib is not (yet) packaged fro Debian 7+.

This means build is failing. Devs and jenkins use the lib from CPAN.

This patch makes the tests skip if the lib is absent.

To test:
- Install Test::DBIx::Class
  $ sudo cpanm Test::DBIx::Class
- Run the tests:
  $ prove t/
=> SUCCESS: Tests pass
- Uninstall Test::DBIx::Class
  $ sudo cpan -U Test::DBIx::Class
- Run the tests:
  $ prove t/
=> SUCCESS: Tests still pass (those needing the lib are skipped)
- Sign off :-D

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. All test pass successful

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15130: useless unitialization warnings when updating authorities
Lyon3 Team [Wed, 4 Nov 2015 16:06:10 +0000 (17:06 +0100)]
Bug 15130: useless unitialization warnings when updating authorities

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Fixes a trivial coding error.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14632: (QA followup) Restore missing "Delete batch" button.
Kyle M Hall [Fri, 6 Nov 2015 14:20:31 +0000 (09:20 -0500)]
Bug 14632: (QA followup) Restore missing "Delete batch" button.

This button was removed by accident in bug 14676

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14632: Fix alert message for single item batch
Indranil Das Gupta [Mon, 3 Aug 2015 04:27:53 +0000 (09:57 +0530)]
Bug 14632: Fix alert message for single item batch

Fixes the incorrect msg "Please select at least label to delete."
for attempts to delete from single patron batches. Notifies the
user that doing so will delete the batch. It disallows direct
deletion, instead suggests the users to use the 'Delete batch'
option assuming the users know what they are doing.

Test plan
=========

1/ Load a single patron batch in edit mode and attempt to delete
   the single record. The JS alert message will inform that "Please
   select at least label to delete."
2/ Apply patch and refresh page and try to delete the single record
   again.
3/ This time the alert will inform the user that doing so will delete
   the batch and should that be desired action to choose the 'Delete
   batch' option from the toolbar.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  It works as before but with an understantable warning message.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15117: Transfer Order: Better user information and translation handling
Marc Véron [Wed, 4 Nov 2015 09:13:46 +0000 (10:13 +0100)]
Bug 15117: Transfer Order: Better user information and translation handling

While transferring an order, a untranslatable JavaScript confirmation
dialog pops up.

This patch moves the information about the order to be transferred to the
top of the screen to better inform the user what order is to be transferred,
and simplifies the confirmation dialog.

To test:
- Apply patch
- Transfer an order from a basket to another basket
- Verify, that on top of the screen an information is displayed about which
  order from which vendor and basket is to be transferred
- Verify that the transfer works OK
- Update a po lang file and confirm you see the string and you are able
  to translate it.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Dialog box with readable & translatable info.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14673: Work around change to AddIssue return
Colin Campbell [Tue, 11 Aug 2015 15:51:53 +0000 (16:51 +0100)]
Bug 14673: Work around change to AddIssue return

Return from AddIssue used to be due date or undef.
Now it is less straightforward returning am issue object
if an issue row is created or undef. If the issue is a renewal
undef is returned. As that case was not handled properly it
caused the server site to crash the listener causing a
communications error on the client.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14045: Fix failing tests if issuing rules exist
Jonathan Druart [Fri, 6 Nov 2015 13:24:39 +0000 (13:24 +0000)]
Bug 14045: Fix failing tests if issuing rules exist

If there is issuing rules defined, one test does not pass as it assumes
there is none defined.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: (QA followup) Add missing transaction
Tomas Cohen Arazi [Thu, 5 Nov 2015 14:05:29 +0000 (11:05 -0300)]
Bug 14836: (QA followup) Add missing transaction

Bug 15081 removed transaction handling from t::lib::TestBuilder so this
patchset had to be ammended to handle it on its own.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: (QA followup) Fix number of unit tests
Kyle M Hall [Fri, 30 Oct 2015 18:42:55 +0000 (14:42 -0400)]
Bug 14836: (QA followup) Fix number of unit tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: Add tests for Koha::Patron::Categor[y|ies]
Jonathan Druart [Thu, 29 Oct 2015 09:08:07 +0000 (09:08 +0000)]
Bug 14836: Add tests for Koha::Patron::Categor[y|ies]

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor*
Jonathan Druart [Thu, 29 Oct 2015 08:47:08 +0000 (08:47 +0000)]
Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor*

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: Add Koha::PatronCategor[y|ies] classes
Jonathan Druart [Wed, 16 Sep 2015 15:50:17 +0000 (16:50 +0100)]
Bug 14836: Add Koha::PatronCategor[y|ies] classes

Note that some of the routines are retrieved from bug 10363 (branch
limitations).
They are not all used in these patch set, but they will permit to
replace the subroutines in C4::Form::MessagingPreferences, in the next
step.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl
Jonathan Druart [Wed, 16 Sep 2015 15:50:43 +0000 (16:50 +0100)]
Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl

Test plan:
Add/edit/remove patron categories from the administration module
(admin/categories.pl).
You should get message feedback after each action.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Operations in admin/category is unchanged, and functionnal

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: DBRev 3.21.00.053
Tomas Cohen Arazi [Thu, 5 Nov 2015 13:49:15 +0000 (10:49 -0300)]
Bug 9468: DBRev 3.21.00.053

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: (QA followup) Remove GetSupportList dependency from updatadatabase.pl
Kyle M Hall [Mon, 24 Aug 2015 10:46:30 +0000 (06:46 -0400)]
Bug 9468: (QA followup) Remove GetSupportList dependency from updatadatabase.pl

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: followup insert ignore
Jonathan Druart [Mon, 20 Apr 2015 09:14:59 +0000 (11:14 +0200)]
Bug 9468: followup insert ignore

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: [QA Followup]
Kyle M Hall [Fri, 17 Apr 2015 16:47:59 +0000 (12:47 -0400)]
Bug 9468: [QA Followup]

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: sample SUGGEST_FORMAT values
Galen Charlton [Mon, 5 May 2014 00:30:24 +0000 (00:30 +0000)]
Bug 9468: sample SUGGEST_FORMAT values

This patch adds some sample values for the SUGGEST_FORMAT
authorized value list for new installations.

To test
-------
[1] Verify that the new SQL inserts added by this patch work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: use new SUGGEST_FORMAT list
Galen Charlton [Mon, 5 May 2014 00:23:19 +0000 (00:23 +0000)]
Bug 9468: use new SUGGEST_FORMAT list

This patch uses the new SUGGEST_FORMAT authorized value list for
populating the list of suggestion item types/document types.  It
also improves the display by using the staff or OPAC description of
the authorised value rather than the code.

To test:

[1] Enter a suggestion via the OPAC and select an item type (which
    I will call "desired format" for the rest of this test plan).
[2] Verify that the saved suggestion displays the desired format
    description in both staff and OPAC.
[3] Verify that organizing the list of suggestions by item type
    now works in the staff interface, rather than displaying "Unknown"
    in each tab header.
[4] Verify that existing suggestions' desired formats are displayed
    correctly.
[5] Verify that suggestions can have their desired format edited
    in the staff inteface.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: define new SUGGEST_FORMAT authorize value
Galen Charlton [Mon, 5 May 2014 00:19:52 +0000 (00:19 +0000)]
Bug 9468: define new SUGGEST_FORMAT authorize value

This patch defines a new authorized called SUGGEST_FORMAT for
populating a list of patron-understandable formats for expressing
how they would prefer suggested items to be purchased.  For
database upgrades, it populates it based on the value returned by the
GetSupportList() routine.

To test
-------
[1] Run the database update.
[2] Verify that there is a new authorised value called SUGGEST_FORMAT
    whose codes and descriptions correspond to the list of "item types"
    available on the patron suggestion form.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 9468: make av-build-dropbox.inc available to OPAC
Galen Charlton [Mon, 5 May 2014 00:13:28 +0000 (00:13 +0000)]
Bug 9468: make av-build-dropbox.inc available to OPAC

This patch makes the av-build-dropbox.inc template include introduced
by the latest patches for bug 766 available to the prog and Bootstrap
themes in the OPAC.

See later patches in this series for testing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: Remove OPAC prog file

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: (RM followup) DBIx update
Tomas Cohen Arazi [Thu, 5 Nov 2015 13:46:19 +0000 (10:46 -0300)]
Bug 8296: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: DBRev 3.21.00.052
Tomas Cohen Arazi [Thu, 5 Nov 2015 13:45:01 +0000 (10:45 -0300)]
Bug 8296: DBRev 3.21.00.052

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty
Katrin Fischer [Thu, 30 Oct 2014 22:18:50 +0000 (23:18 +0100)]
Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty

To test:
- make sure you have a subscription where only some fields have a published date (text) set
- check the subscription detail page, issues tab
- check the serial collection page
- both pages should show an empty field, when published date (text) has not been set

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Fix unit tests in t/db_dependent/Serials.t
Julian Maurice [Fri, 10 Oct 2014 07:22:54 +0000 (09:22 +0200)]
Bug 8296: Fix unit tests in t/db_dependent/Serials.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Display publisheddatetext in OPAC bootstrap theme
Julian Maurice [Thu, 31 Jul 2014 08:37:48 +0000 (10:37 +0200)]
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Don't fill text field automatically
Julian Maurice [Tue, 23 Jul 2013 07:43:02 +0000 (09:43 +0200)]
Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Follow up for QA
Julian Maurice [Fri, 14 Sep 2012 15:01:46 +0000 (17:01 +0200)]
Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: set input maxlength to the same of sql field length
Julian Maurice [Fri, 14 Sep 2012 14:20:01 +0000 (16:20 +0200)]
Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8296: Add descriptive (text) published date field for serials
Julian Maurice [Fri, 22 Jun 2012 15:25:54 +0000 (17:25 +0200)]
Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14544: (RM followup) DBIx update
Tomas Cohen Arazi [Thu, 5 Nov 2015 13:40:57 +0000 (10:40 -0300)]
Bug 14544: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>