]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoMerge remote-tracking branch 'origin/new/bug_7310'
Paul Poulain [Fri, 6 Apr 2012 14:02:11 +0000 (16:02 +0200)]
Merge remote-tracking branch 'origin/new/bug_7310'

12 years ago7368 Followup for indentation in VirtualShelves.pm
Marcel de Rooy [Thu, 5 Apr 2012 13:58:22 +0000 (15:58 +0200)]
7368 Followup for indentation in VirtualShelves.pm

Corrects some further indentation issues, removes last tab from file.
Related to report 7310.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
12 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Fri, 6 Apr 2012 13:12:28 +0000 (15:12 +0200)]
Merge remote-tracking branch 'origin/new/bug_7143'

12 years agoItalian translation teams
Zeno Tajoli [Sat, 31 Mar 2012 08:08:29 +0000 (10:08 +0200)]
Italian translation teams

http://bugs.koha-community.org/show_bug.cgi?id=7143

12 years agoBug 7785: Remove unused function columns() which uses a MySQLism.
Marc Balmer [Fri, 23 Mar 2012 16:37:02 +0000 (17:37 +0100)]
Bug 7785: Remove unused function columns() which uses a MySQLism.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoStop unnecessary warnings in get_language
Colin Campbell [Mon, 2 Apr 2012 14:06:28 +0000 (15:06 +0100)]
Stop unnecessary warnings in get_language

Refactor code to be more idiomatic and clarify its intention was testing
undef against languages causing log warn was creating and assigning to
unnecessary variables calling accept_language with an undef is an
expensive way to get undef returned to the caller test we are asking it
a meabingful question use any rather than first ( we dont care about
firstness it should be unique anyway but it obscures the meaning of the
test ) split takes a pattern not a string

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Having put my hands recently in this part of Koha code, I can confirm
that this patch fix log warnings, and add clarity and conciseness.

http://bugs.koha-community.org/show_bug.cgi?id=7874
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7284'
Paul Poulain [Wed, 4 Apr 2012 16:18:26 +0000 (18:18 +0200)]
Merge remote-tracking branch 'origin/new/bug_7284'

12 years agobug 7284: fix package build problem, move BEGIN into new
MJ Ray [Thu, 29 Mar 2012 17:35:04 +0000 (18:35 +0100)]
bug 7284: fix package build problem, move BEGIN into new

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7766 - C4/Auth.pm: emit DEBUG output to STDERR
Dobrica Pavlinusic [Wed, 21 Mar 2012 08:26:22 +0000 (09:26 +0100)]
Bug 7766 - C4/Auth.pm: emit DEBUG output to STDERR

writing to STDOUT breaks plack when running with DEBUG=1

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2780 - Capitalize strings consistently (Acquisitions pages)
Owen Leonard [Tue, 3 Apr 2012 18:22:42 +0000 (14:22 -0400)]
Bug 2780 - Capitalize strings consistently (Acquisitions pages)

Correcting capitalization on strings in Acquisitions templates

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (miscellaneous)
Owen Leonard [Tue, 3 Apr 2012 15:49:16 +0000 (11:49 -0400)]
Bug 2780 - Capitalize strings consistently (miscellaneous)

Correcting all remaining includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Tools)
Owen Leonard [Tue, 3 Apr 2012 15:36:06 +0000 (11:36 -0400)]
Bug 2780 - Capitalize strings consistently (Tools)

Correcting Tools-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Reports)
Owen Leonard [Tue, 3 Apr 2012 15:31:22 +0000 (11:31 -0400)]
Bug 2780 - Capitalize strings consistently (Reports)

Correcting Reports-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Administration)
Owen Leonard [Tue, 3 Apr 2012 15:23:10 +0000 (11:23 -0400)]
Bug 2780 - Capitalize strings consistently (Administration)

Correcting System administration-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging)
Owen Leonard [Tue, 3 Apr 2012 15:09:53 +0000 (11:09 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging)

Correcting Cataloging-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Serials)
Owen Leonard [Tue, 3 Apr 2012 15:06:11 +0000 (11:06 -0400)]
Bug 2780 - Capitalize strings consistently (Serials)

Correcting Serials-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Patrons)
Owen Leonard [Tue, 3 Apr 2012 14:58:54 +0000 (10:58 -0400)]
Bug 2780 - Capitalize strings consistently (Patrons)

Correcting Patron-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Patron cards)
Owen Leonard [Tue, 3 Apr 2012 14:29:38 +0000 (10:29 -0400)]
Bug 2780 - Capitalize strings consistently (Patron cards)

Correcting Patron card creator-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Labels)
Owen Leonard [Tue, 3 Apr 2012 14:25:08 +0000 (10:25 -0400)]
Bug 2780 - Capitalize strings consistently (Labels)

Correcting Labels-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Circulation)
Owen Leonard [Tue, 3 Apr 2012 14:15:07 +0000 (10:15 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation)

Correcting Circulation-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Budgets)
Owen Leonard [Tue, 3 Apr 2012 13:36:44 +0000 (09:36 -0400)]
Bug 2780 - Capitalize strings consistently (Budgets)

Correcting Budgets-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (catalog)
Owen Leonard [Tue, 3 Apr 2012 13:32:45 +0000 (09:32 -0400)]
Bug 2780 - Capitalize strings consistently (catalog)

Correcting catalog-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently
Owen Leonard [Tue, 3 Apr 2012 13:26:47 +0000 (09:26 -0400)]
Bug 2780 - Capitalize strings consistently

Corrections to Authorities-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently
Owen Leonard [Tue, 3 Apr 2012 13:20:45 +0000 (09:20 -0400)]
Bug 2780 - Capitalize strings consistently

Corrections to Acquisitions include files. Patch
also includes some corrections to unescaped ampersands.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7482: overdues report downloads without names
Katrin Fischer [Sun, 1 Apr 2012 16:20:05 +0000 (18:20 +0200)]
Bug 7482: overdues report downloads without names

This patch is an alternate patch for the bug. Instead of having
one column 'name' for a concatenated first and last name it
adds 2 separate columns to the exported csv file.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7876 - Add ids to divs and spans with ids in opac-user.tt
Kyle M Hall [Mon, 2 Apr 2012 17:57:36 +0000 (13:57 -0400)]
Bug 7876 - Add ids to divs and spans with ids in opac-user.tt

This commit adds an id to each div, and adds spans where
there are no appropriate divs to add. In addition, non-static text
such as the expiration date are wrapped in a special sub-span so
that data can be pulled and reused when customizing via jQuery.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate
Magnus Enger [Wed, 4 Apr 2012 06:49:56 +0000 (08:49 +0200)]
Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate

The apache accesslogs suggested by the default config files are called
*_log, which results in them not getting picked up by logrotate, which
looks for *.log. This patch changes the suggested filenames to *.log.

To test:
Not much to test here, just apply the patch and check that all
occurences of TransferLog and CustomLog are now on the form *.log

All the lines where these occur are commented out, so this will
not actually change any behaviour.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
12 years agoBug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks
Magnus Enger [Fri, 30 Mar 2012 07:59:03 +0000 (09:59 +0200)]
Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks

This patch does three things:

- Add a copyright comment to normarc_fastadd_framework.sql
- Change the value of marc_subfield_structure.hidden from -1 to 0 for
  several subfields of 952, in both the default and fast add framework,
  using this SQL statement:
  update marc_subfield_structure set hidden = 0 where tagfield = '952' and hidden = -1;
- Add the maxlength column introduced by bug 7263 to all rows in
  marc_subfield_structure, setting the following maxlengths:
  000 = 24
  008 = 40
  all other subfields = 9999

The format of the SQL files is the one that is produced by exporting the
frameworks from the Web UI, with added copyright comments at the top.

To test:
- Install nb-NO
- Run through the web installer in Norwegian on an empty database
- Select NORMARC as the marcflavour
- Be sure to select the fast add framework ("Rammeverk for
  hurtigkatalogisering" under "Valgritt")
- Check in Home › Administration › MARC Frameworks that 000 and 008
  for both frameworks have the right length
- Add a dummy record so you get to the item edit screen and check that
  the form for subfields looks good. The subfields that are shown
  should be 01234578abcdefghjoptuvwyz and all subfields should have
  a text box or a dropdown associated with them. Check this for
  for both the default and fast add frameworks

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Walked through the test plan, seems to work well.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7858 - Missing packages from install_misc/ubuntu.packages
Owen Leonard [Mon, 2 Apr 2012 12:55:06 +0000 (08:55 -0400)]
Bug 7858 - Missing packages from install_misc/ubuntu.packages

- Adding missing dependencies to install_misc/ubuntu.packages
- Removing items from CPAN instructions which are installed
  as packages

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Seems to add all necessary packages.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7860 - /virtualshelves/addbybiblionumber.pl plack scoping
Dobrica Pavlinusic [Fri, 30 Mar 2012 23:30:26 +0000 (01:30 +0200)]
Bug 7860 - /virtualshelves/addbybiblionumber.pl plack scoping

Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 115.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 129.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 134.
Variable "$newvirtualshelf" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 135.
Variable "$sortfield" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 136.
Variable "$category" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 137.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 137.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 139.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 140.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 143.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 145.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 151.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 153.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 157.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 165.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 173.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 178.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 180.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 188.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 196.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 204.
Variable "$newshelf" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 205.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 206.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 207.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 209.
Variable "$cookie" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 209.
Can't call method "param" on an undefined value at /srv/koha/virtualshelves/addbybiblionumber.pl line 115.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7864: Little changes to the display
Katrin Fischer [Sun, 1 Apr 2012 12:33:31 +0000 (14:33 +0200)]
Bug 7864: Little changes to the display

Changes the display of subscribers a bit.

- Makes each name a link to the patron account instead of having a separate
  'View' link behind each name
- Show the title and subscrption number as link to the subscription detail
  page instead of just 'subscription'

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7864: Reintroduce list of subscribers to a serial alert message
Katrin Fischer [Sun, 1 Apr 2012 07:49:06 +0000 (09:49 +0200)]
Bug 7864: Reintroduce list of subscribers to a serial alert message

Adds a link to the existing template from the serial detail page:

Patron alert with: RLIST (subscribers)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7888 - Permission for "change password" button in circ toolbar should be "borrowe...
Liz Rea [Tue, 3 Apr 2012 15:35:28 +0000 (10:35 -0500)]
Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"

Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers.

To test:
- With a staff user with borrowers permission, verify the change password button is shown for a normal patron.
- With a staff user without borrowers permission, verify the change password button does not appear.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7291 follow-up DBRev number
Paul Poulain [Tue, 3 Apr 2012 16:32:25 +0000 (18:32 +0200)]
bug 7291 follow-up DBRev number

12 years agoBug 7291: Followup: removes backquotes
Jonathan Druart [Tue, 3 Apr 2012 14:02:32 +0000 (16:02 +0200)]
Bug 7291: Followup: removes backquotes

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7291: Adds new field aqbooksellers.deliverytime
Jonathan Druart [Mon, 13 Feb 2012 09:05:17 +0000 (10:05 +0100)]
Bug 7291: Adds new field aqbooksellers.deliverytime

New field deliverytime in aqbooksellers table. It is an estimated
delivery time for orders (in days).
You can set this delay on the supplier modification page.
It is used in the late orders search.

The order estimated date is the aqbasket.closedate +
aqbooksellers.deliverytime

If you set a delay, the query check if closedate <= today - delay

If you set a "delivery time from" and a "delivery time to", the query check if
$delivery_time_from <= aqbooksellers.deliverytime is not NULL and if
closedate + deliverytime >= $delivery_time_to
if there is not a time_to then $delivery_time_to = the current date.

12 years agoBug 7851 - circ/circulation.pl plack scoping
Dobrica Pavlinusic [Fri, 30 Mar 2012 16:58:53 +0000 (18:58 +0200)]
Bug 7851 - circ/circulation.pl plack scoping

Errors:

Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448.
Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456.
Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458.
Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459.
Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459.
Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461.
Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461.

Test scenario:
1. go to circulation page
2. verify errors in console output of plack
3. apply patch
4. reload and verify that errors are gone

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7859 - members/pay.pl plack scoping
Dobrica Pavlinusic [Fri, 30 Mar 2012 22:19:24 +0000 (00:19 +0200)]
Bug 7859 - members/pay.pl plack scoping

Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 112.
Variable "$borrower" is not available at /srv/koha/members/pay.pl line 129.
Variable "$input" is not available at /srv/koha/members/pay.pl line 142.
Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 157.
Variable "$user" is not available at /srv/koha/members/pay.pl line 171.
Variable "$input" is not available at /srv/koha/members/pay.pl line 172.
Variable "$input" is not available at /srv/koha/members/pay.pl line 181.
Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 187.
Variable "$branch" is not available at /srv/koha/members/pay.pl line 187.
Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 222.
Variable "$input" is not available at /srv/koha/members/pay.pl line 239.
Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 246.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7863 - opac-addbybiblionumber.pl plack scoping
Dobrica Pavlinusic [Sat, 31 Mar 2012 22:28:11 +0000 (00:28 +0200)]
Bug 7863 - opac-addbybiblionumber.pl plack scoping

Test scenario:

1. issue search query
2. select 1 result
3. add to: new list, list-1, private
4. select 2 results
5. add to (exiting) list-1
4. select 3 results
6. add to: new list, list-2, public
7. using lists drop-down, view and delete list-1 and list-2

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7562 Add strict & warnings to KohaDates Plugin
Colin Campbell [Fri, 23 Mar 2012 12:29:02 +0000 (12:29 +0000)]
Bug 7562 Add strict & warnings to KohaDates Plugin

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
http://bugs.koha-community.org/show_bug.cgi?id=7814
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7866: z39.50 search list ordered by rank
Adrien Saurat [Mon, 2 Apr 2012 08:43:58 +0000 (10:43 +0200)]
Bug 7866: z39.50 search list ordered by rank

In the z39.50 cataloging search page, the servers
are now sorted by rank and name.

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
12 years ago7868 Followup for opac
Marcel de Rooy [Mon, 2 Apr 2012 10:54:28 +0000 (12:54 +0200)]
7868 Followup for opac

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial fix. Counterpart for staff by Adrien Saurat.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7868: cleans logs when doing a Search on the intranet
Adrien Saurat [Mon, 2 Apr 2012 10:30:06 +0000 (12:30 +0200)]
Bug 7868: cleans logs when doing a Search on the intranet

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended the patch: combined if statements and added a check for pubshelves too.

12 years agoBug 1662: Is there a difference between Full and Simplified for Serials History
Katrin Fischer [Mon, 2 Apr 2012 19:01:26 +0000 (21:01 +0200)]
Bug 1662: Is there a difference between Full and Simplified for Serials History

Changes description of system preference SubscriptionHistory:

When showing the subscription information for a bibliographic record,
preselect [brief history|full history] view of the serial issues.

To test:
1) Verify new description shows in system preference editor (tab serials)
2) Verify description is correct (OPAC > Subscription tab > more details)

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoUse hour or day deltas to calculate overdue durations
Colin Campbell [Thu, 15 Sep 2011 11:42:12 +0000 (12:42 +0100)]
Use hour or day deltas to calculate overdue durations

If durations are calculated by subtraction they will use units
larger than those we care about and these are not convertable
to the smaller units we are attempting to enumerate
Use the appropriate delta methods to calculate theee fines

Adds a separate hours_between method to calendar
This should strictly be checking opening hours (of which
closed days are a special case) of the relevant branch
These need adding to branches

http://bugs.koha-community.org/show_bug.cgi?id=7852
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA comment: renamed "days_minus_grace" variable to "units_minus_grace"
Also added POD to _get_chargeable_units

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6434 - Ukrainian and Russian MARC sql-tables
Serhij Dubyk {Сергій Дубик} [Fri, 30 Mar 2012 22:20:18 +0000 (01:20 +0300)]
Bug 6434 - Ukrainian and Russian MARC sql-tables

Changes: Marc21 support, 995 for items (Unimarc), authorities types for both
MARC's, many small field/subfield changes

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
It works, doesn't break anything, seems to be in Ukrainian/Russian (I can't
judge).

It's a huge patch (21M). That's why it's attached as a bz2 archive: so the
archive must be downloaded, decompressed, and then applied.

General remark: Adding this patch to Koha will increase substantially Koha git
repository size. It shows that non-code files (.po files, SQL files)
could/should be managed outside Koha core repository. See this discussion:

http://wiki.koha-community.org/wiki/Git_Splitting_and_Shrinking

Here is my test plan:

[1]  Apply the patch on master
[2]  Install ru-RU and uk-UA languages:
     cd misc/translator
     ./translate ru-RU uk-UA
[3]  re-create Koha DB:
     DROP DATABASE koha;
     CREATE DATABASE koha;
[4]  Load Koha pro interface: get web installer
[5]  Choose ru-RU language
[6]  Everything is in Russian. Click blindly on button until reaching the
     page where to choose Unimarc/Marc21.
[7]  Choose Unimarc.
[8]  Tick on everything to load all UNIMARC SQL files.
[9]  All SQL are loaded without any error.
[10] Check Koha cataloguing.
[11] Go to [3] and choose Marc21 at step [7].
[12] Go to [3] and choose uk-UA at step [5].
[13] Go to [3] and choose uk-UA at step [5] and Marc21 at step [7].

12 years agoBug 7836 - Poor English on Patron Attribute Form
Jonathan Druart [Thu, 29 Mar 2012 14:03:03 +0000 (16:03 +0200)]
Bug 7836 - Poor English on Patron Attribute Form

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(Poor being subjective, being an en-NZ speaker, all the US
misspellings are poor to me :))

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7821 - fix C4::Templates::_current_language
Dobrica Pavlinusic [Fri, 30 Mar 2012 17:41:02 +0000 (19:41 +0200)]
Bug 7821 - fix C4::Templates::_current_language

Bareword "C4::Templates::_current_language" not allowed while "strict subs" in use at /home/oleonard/kohaclone/C4/XSLT.pm line 175.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fixes the problem.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7821 follow-up: escaping {} in regexp
Paul Poulain [Thu, 29 Mar 2012 15:23:50 +0000 (17:23 +0200)]
bug 7821 follow-up: escaping {} in regexp

12 years agoBug 7821 - {langcode} will be replaced with current interface language
Dobrica Pavlinusic [Sat, 24 Mar 2012 16:47:57 +0000 (17:47 +0100)]
Bug 7821 - {langcode} will be replaced with current interface language

This makes bug 4032 support multi-language Koha installation which is important
for some of Koha users.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) After update XSLT system preferences are set to 'default'. All views
(OPAC and staff, results and detail page) work and switching languages
selects the correct translated file.

2) Leaving empty works and normal views are used.

3) Putting in a single URL without placeholder works.

4) Putting in a URL with placeholder works. Created local directories
have to match the language codes.

NOTE: In order to make the URLs and patchs work, the Utils file needs to be
copied too.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4032 follow-up: removing ` in syspref
Paul Poulain [Thu, 29 Mar 2012 14:59:34 +0000 (16:59 +0200)]
Bug 4032 follow-up: removing ` in syspref

12 years agoBug 4032 follow-up: DBRev number
Paul Poulain [Thu, 29 Mar 2012 14:59:13 +0000 (16:59 +0200)]
Bug 4032 follow-up: DBRev number

12 years agoBug 4032 XSLT systempreference takes a path to file rather than YesNo
Stéphane Delaune [Wed, 8 Feb 2012 11:12:16 +0000 (12:12 +0100)]
Bug 4032 XSLT systempreference takes a path to file rather than YesNo

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
I am signing it off because it doesn't break anything and I will report
another bug for language issues described in my previous comment.

Removed MySQLism backquotes

12 years agoBug 7729 : svc/bib: support appending ?items=1 to the URL to fetch or modify items
MJ Ray [Thu, 22 Mar 2012 16:40:39 +0000 (16:40 +0000)]
Bug 7729 : svc/bib: support appending ?items=1 to the URL to fetch or modify items

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7835 - submit and cancel buttons on diff lines on notices
Owen Leonard [Wed, 28 Mar 2012 14:00:18 +0000 (10:00 -0400)]
Bug 7835 - submit and cancel buttons on diff lines on notices

Changing markup of cancel button to match standard Koha pattern.
Also correcting some invalid markup:
 - unescaped ampersands
 - invalid form action attributes
 - improperly nested elements in <ol>
 - invalid "for" on label

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7641 follow-up: remove some unconditionnal warns
Paul Poulain [Thu, 29 Mar 2012 13:10:34 +0000 (15:10 +0200)]
bug 7641 follow-up: remove some unconditionnal warns

12 years agobug 7641 follow-up: activate use strict (see coding guidelines)
Paul Poulain [Thu, 29 Mar 2012 13:10:16 +0000 (15:10 +0200)]
bug 7641 follow-up: activate use strict (see coding guidelines)

12 years agobug 7641 follow-up DBRev number
Paul Poulain [Thu, 29 Mar 2012 13:09:43 +0000 (15:09 +0200)]
bug 7641 follow-up DBRev number

12 years agoBug 7641: Suspend Reserves
Kyle M Hall [Thu, 1 Mar 2012 16:57:58 +0000 (11:57 -0500)]
Bug 7641: Suspend Reserves

Adds the ability to suspend reserves. The new system preference
AutoResumeSuspendedHolds enables the ability to set a date for
a suspended hold to automatically be resumed.

When a hold is suspended, it will continue to increase in priority
as the holds above it are fulfilled. If the first holds in line
to be filled are suspended, the first non-suspened hold in line
will be used when an item can fulfill a hold that has been placed.

http://bugs.koha-community.org/show_bug.cgi?id=7641
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested with the preference on and off:
1. placed several holds in the staff client
2. suspended some with a date
3. suspended some without a date
4. triggered hold message by checking in for hold with suspensions
5. the suspended hold was skipped as it should be
6. tested suspending holds in the OPAC w and w/out dates
7. ran the cron to clear suspensions with dates

All the above tests worked as expected. Signing off.

12 years agoBug 7701: Error when sending serial alerts
Jared Camins-Esakov [Sun, 11 Mar 2012 16:13:15 +0000 (12:13 -0400)]
Bug 7701: Error when sending serial alerts

Probably due to bug 6875, C4::Letters is no longer used by C4::Serials, so that
when SendAlerts is called (exactly when this happens is a mystery to me), you
will get an error. Adding a "require C4::Letters;" and prefixing SendAlerts to
C4::Letters:: should fix it.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes the perl error. Steps to reproduce:

1) Create a subscription and set patron notification to "Routling list" -
this is necessary, so that a link to email notifications shows up in the OPAC.
2) Search for the serial record in the OPAC and click on the more details
view from the subscriptions tab. Subscribe to email notifications.
3) Go back into the serials module and receive and issue for the serial.
Before the patch a nasty perl error will be shown, after the patch
receiving works.

I couldn't confirm that the email was sent out with my setup, but this patch
certainly fixes serial receive.

[Update 2011-02-29] Fixed the typo and retested. Looks good, but couldn't check
if the mail was actually sent.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7617: Sort authority results by authid
Jared Camins-Esakov [Sun, 11 Mar 2012 17:48:43 +0000 (13:48 -0400)]
Bug 7617: Sort authority results by authid

Add the option of sorting authority search results by authid, and instruct the
FirstMatch and LastMatch linkers to use that sort order rather than the default
search order.

To test:
1. Install new Zebra authorities config
    etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
    etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
    etc/zebradb/marc_defs/marc21/authorities/record.abs, and
    etc/zebradb/marc_defs/unimarc/authorities/record.abs
2. Reindex authorities in Zebra
3. Set LinkerModule to FirstMatch or LastMatch
4. Add two identical authority records, and a bib record with a heading that
   matches them
5. Run misc/link_bibs_to_authorities.pl on that record
6. Confirm that the authid that's been inserted into subfield $9 of that
   heading is the first, if you selected FirstMatch, or last if you selected
   LastMatch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I followed the test plan and checked that for "Last match" and "First match"
the correct authority was selected and linked to the record.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and UseICU...
Magnus Enger [Thu, 16 Feb 2012 11:07:35 +0000 (12:07 +0100)]
Bug 7537 - Implement TraceCompleteSubfields, TraceSubjectSubdivisions and UseICU for NORMARC XSLT

IMPORTANT! This patch relies on the patch for Bug 7092, which is now pushed to
master.

As the title says, this patch implements TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU for NORMARC XSLT, both for the OPAC
and the Intranet. This affects how clickable subject-links are constructed.

To make this work the indexing of MARC fields in the 600 range is changed
to include "Subject:p" in several new places.

To test:

Find a record with a "complex" subject, like "Internet -- Law and legislation".
MARC21 and NORMARC are very similar in how they handle subjects, so testing
on a MARC21 database should be OK. (Changes in indexing reflect changes already
made to the MARC21 indexing.)

Make sure you have these syspref settings:
- marcflavour = NORMARC
- XSLTDetailsDisplay = using XSLT stylesheets
- OPACXSLTDetailsDisplay = using XSLT stylesheets

(Ideally, testing should be done on a real NORMARC setup, but since the changes
to indexing only reflect how it's already done in MARC21, I think testing
on a MARC21 installation with marcflavour = NORMARC should be OK.)

Now try the different combinations of TraceCompleteSubfields,
TraceSubjectSubdivisions and UseICU, and check the format of the
clickable links, both in the OPAC and staff client. Here's what you should
be seeing:

1.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
  opac-search.pl?q=su:"Internet"
UseICU = Using
  opac-search.pl?q=su:{Internet}

2.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
UseICU = Not using
  opac-search.pl?q=su,complete-subfield:"Internet"
UseICU = Using
  opac-search.pl?q=su,complete-subfield:{Internet}

3.
TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
UseICU = Not using
  opac-search.pl?q=(su:"Internet") AND (su:"Law and legislation.")
UseICU = Using
  opac-search.pl?q=(su:{Internet}) AND (su:{Law and legislation.})

4.
TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
UseICU = Not using
  opac-search.pl?q=(su,complete-subfield:"Internet") AND (su,complete-subfield:"Law and legislation.")
UseICU = Using
  opac-search.pl?q=(su,complete-subfield:{Internet}) AND (su,complete-subfield:{Law and legislation.})

UPDATE 2012-03-23
- Change the syspref TracingQuotes to UseICU, see bug 7092
- Change boolean operator from "and" to "AND", see bug 7695

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Note: UseControlnumber must be turned off.

1) Works.
2) Works.
3) Works.
4) Works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE
Magnus Enger [Mon, 26 Mar 2012 20:05:45 +0000 (22:05 +0200)]
Bug 7436 - Set itemtypes.rentalcharge = 0 in sample data for nb-NO and de-DE

Set the rentalcharge = 0 for sample itemtypes (except Music for nb-NO).

To test:
Run through the web-installer for nb-NO and de-DE, and check that
itemtypes are displayed correctly for each language.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>.
Note: You have to install the language first in order to be able
to select it in the web installer. There was a problem
in the po files for nb-NO that kept all files from being created
correctly. I fixed the po file and did an installation with all sample
files. There is a problem with z3950servers.sql that is not caused
by this patch:
z3950servers.sql
ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1

Web installer for de-DE ran without problems on the sample files.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4819: Add ids to OPAC detail page
Katrin Fischer [Thu, 22 Mar 2012 15:34:28 +0000 (16:34 +0100)]
Bug 4819: Add ids to OPAC detail page

Patch adds an unique id to every item tab and
to every column in the items table on the holdings tab.

http://bugs.koha-community.org/show_bug.cgi?id=4819
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7485 - Cannot edit barcode on Fast Add
Kyle M Hall [Tue, 27 Mar 2012 16:01:33 +0000 (12:01 -0400)]
Bug 7485 - Cannot edit barcode on Fast Add

Simple fix, a special case was added for the fast add framework
in the case that an item was being checked out that had not been
catalogued. In that case, the barcode was being passed as a parameter
through addbiblio.pl to additem.pl.

This barcode param was used to overwrite the existing value, so if
no barcode param was passed ( which is only the case with fast adds
from the circ screen ), the barcode field would appear empty in the
items editor.

This commit causes that special case code to check for an existing
barcode value first, and only use the cgi parameter 'branch' in the
case that there is no existing barcode value.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Editing barcode of fast added item now works. Passes t xt

Recommend this for 3.6 release.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 6858 follow-up indenting with spaces
Paul Poulain [Wed, 28 Mar 2012 16:10:40 +0000 (18:10 +0200)]
bug 6858 follow-up indenting with spaces

12 years agoBug 6858: Adds staticfines.pl for static fines processing
Matthias Meusburger [Wed, 23 Mar 2011 15:19:07 +0000 (16:19 +0100)]
Bug 6858: Adds staticfines.pl for static fines processing

Add a tool to calculate static fine. For example, 7 days left = 1€ fixed fine

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6199'
Paul Poulain [Wed, 28 Mar 2012 15:54:55 +0000 (17:54 +0200)]
Merge remote-tracking branch 'origin/new/bug_6199'

12 years agoBug 6199 - allow bulkmarkimport.pl to remove duplicate barcodes
Robin Sheat [Mon, 18 Apr 2011 07:42:58 +0000 (19:42 +1200)]
Bug 6199 - allow bulkmarkimport.pl to remove duplicate barcodes

This adds the -dedupbarcode option that allows bulkmarkimport to erase
a barcode but keep the item of any items it finds with duplicate
barcodes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7829 - reports/ remove all exit(1) for plack
Dobrica Pavlinusic [Mon, 26 Mar 2012 14:49:12 +0000 (16:49 +0200)]
Bug 7829 - reports/ remove all exit(1) for plack

In Bug 7772 Ian correctly noted that reports have exit(1) all over the place.
This is left over from old code, and this patch changes them to exit(0).

I decided to use plain exit as opposed to explicit exit(0) since it produces
cleaner code, but I'm welcoming suggestion on this.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"
Katrin Fischer [Sat, 24 Mar 2012 10:40:16 +0000 (11:40 +0100)]
Bug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"

"New" for adding new patrons is hard to translate and is not consistent
with the naming of similar buttons in other parts of Koha.

Patch changes "New" to "New patron".

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Patch does what it says and ii makes sense to change the wording.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7695 - Change boolean operator from "and" to "AND"
Magnus Enger [Tue, 20 Mar 2012 12:45:48 +0000 (13:45 +0100)]
Bug 7695 - Change boolean operator from "and" to "AND"

When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and
TraceSubjectSubdivisions = Include, subject sudivisions are
combined with the boolean operator "and". Currently, this word is
translated along with other occurrences of the same word, resulting
in a false "no records found" for users of non-English templates.

This patch replaces "and" with "AND" which should have no effect on
searching (since Zebra is case-insensitive in this regard) but will
make the boolean operator stand out from other uses of "and" in
translations.

TraceSubjectSubdivisions is currently only implemented in MARC21,
so UNIMARC and NORMARC is not affected.

To test:

XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT
TraceSubjectSubdivisions = Include
marcflavour = MARC21

Find a record with a clickable subject that includes one or more
subdivisions and check that the subdivisions are combined with
"AND", not "and". Check that you get the expected result when
clicking on the subject.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test and works as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7837 - nb-NO z3950servers.sql misses column names
Magnus Enger [Tue, 27 Mar 2012 20:35:35 +0000 (22:35 +0200)]
Bug 7837 - nb-NO z3950servers.sql misses column names

Fix installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql so it
includes column names.

To test:
- Install the nb-NO language
- Run through the web installer, and make sure to select the optional
  ("Valgfritt") z3950servers.sql file
- Check there are no errors
- Check that the Z39.50 errors are displayed OK in
  Home › Administration › Z39.50 Servers

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Web installer runs without any errors now and I checked that
the Z39.50 servers were imported correctly and can be edited.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7727 - NORMARC XSLT OPAC detail view shows double tabs
Magnus Enger [Fri, 23 Mar 2012 14:59:59 +0000 (15:59 +0100)]
Bug 7727 - NORMARC XSLT OPAC detail view shows double tabs

With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT,
the detail view displays a double set of tabs for Normal/MARC/ISBD
views, one above the title and one below.

To test:
marcflavour = NORMARC
OPACXSLTDetailsDisplay = Using XSLT

Since the contents of the recaords do not matter here, the patch
can be tested on MARC records of any flavour.

- Check that double tabs are shown
- Apply the patch
- Check that only the set of tabs at the top is shown

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5354 follow-up : dealing with a wrong regexp
Paul Poulain [Wed, 28 Mar 2012 14:17:45 +0000 (16:17 +0200)]
Bug 5354 follow-up : dealing with a wrong regexp

I could not reproduce the working behaviour when I found that the tiny follow-up introduced a bug
| being a reserved char in regexp, split '|' is not splitting on '|' ! we must write '\|' !

12 years agobug 5354 follow-up DBRev number
Paul Poulain [Wed, 28 Mar 2012 14:15:34 +0000 (16:15 +0200)]
bug 5354 follow-up DBRev number

12 years agoBug 5354: Followup. Change separator
Jonathan Druart [Fri, 23 Mar 2012 16:05:46 +0000 (17:05 +0100)]
Bug 5354: Followup. Change separator

12 years agoBug 5354: Partial duplication of a subscription
Jonathan Druart [Thu, 8 Mar 2012 09:45:32 +0000 (10:45 +0100)]
Bug 5354: Partial duplication of a subscription

A new syspref (SubscriptionDuplicateDroppedInput) contains the list of fields to
duplicate when duplicating a subscription. The library will be able to
define that, for example, the internal note should not be duplicated

Test plan:
On the detail subscription page, click Edit > Edit as New (Duplicate):
All the information must be copied from the original subscription.

Fill the syspref SubscriptionDuplicateDroppedInput with a list of fields
you don't want to be duplicated (e.g. location;notes;branchcode).

Repeat the duplicate action. Normally, information for these fields are
not copied.

Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
12 years agoBug 7786 Adding More Lists-option to the Add-to combo of staff search results
Marcel de Rooy [Thu, 22 Mar 2012 06:35:37 +0000 (07:35 +0100)]
Bug 7786 Adding More Lists-option to the Add-to combo of staff search results

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5549 : Fixing the test to only run if the test data exists
Chris Cormack [Thu, 22 Mar 2012 19:32:38 +0000 (08:32 +1300)]
Bug 5549 : Fixing the test to only run if the test data exists

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
test passes after the patch. Win.

12 years agoBug 7775 - tools/upload-file.pl: scoping for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:47:49 +0000 (11:47 +0100)]
Bug 7775 - tools/upload-file.pl: scoping for plack

$uploaded_file is now scoped with our, and we set correct filename

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7799 - admin/marctagstructure.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:05:22 +0000 (14:05 +0100)]
Bug 7799 - admin/marctagstructure.pl plack scoping

duplicate_framework needs $dbh so we get it from C4::Context

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7773 - serials/subscription-add.pl scope for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:28:54 +0000 (11:28 +0100)]
Bug 7773 - serials/subscription-add.pl scope for plack

This fixes scope of $query and $nextexpected

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7801 - admin/patron-attr-types.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:13:21 +0000 (14:13 +0100)]
Bug 7801 - admin/patron-attr-types.pl plack scoping

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7800 - admin/matching-rules.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 13:08:47 +0000 (14:08 +0100)]
Bug 7800 - admin/matching-rules.pl plack scoping

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7790 - tools/manage-marc-import.pl breaks with plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 10:26:56 +0000 (11:26 +0100)]
Bug 7790 - tools/manage-marc-import.pl breaks with plack

transfer $template to add_matcher_list for correct scoping
and score $dbh and $runinbackground with our

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7798 - admin/item_circulation_alerts.pl plack scoping
Dobrica Pavlinusic [Thu, 22 Mar 2012 12:58:29 +0000 (13:58 +0100)]
Bug 7798 - admin/item_circulation_alerts.pl plack scoping

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7795 - admin/authorised_values.pl breaks with plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:01:06 +0000 (12:01 +0100)]
Bug 7795 - admin/authorised_values.pl breaks with plack

scoping fixes for Variable "*" is not available errors

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7470 follow-up, fix POD doc
Paul Poulain [Mon, 26 Mar 2012 15:53:28 +0000 (17:53 +0200)]
bug 7470 follow-up, fix POD doc

12 years agoBug 7797 - admin/currency.pl needs scoping for plack
Dobrica Pavlinusic [Thu, 22 Mar 2012 11:53:13 +0000 (12:53 +0100)]
Bug 7797 - admin/currency.pl needs scoping for plack

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack
Dobrica Pavlinusic [Wed, 21 Mar 2012 10:23:20 +0000 (11:23 +0100)]
Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt
Ian Walls [Sun, 25 Mar 2012 22:20:58 +0000 (18:20 -0400)]
Bug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt

Replaces formattedwaitingdate with just waitingdate, since no longer create and export
that template variable

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 14:18:27 +0000 (15:18 +0100)]
Bug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

12 years agoBug 7743: Update opac-showreviews.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 14:05:24 +0000 (15:05 +0100)]
Bug 7743: Update opac-showreviews.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
12 years agoBug 7743: Update opac-userupdate.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:57:51 +0000 (14:57 +0100)]
Bug 7743: Update opac-userupdate.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
12 years agoBug 7743: Update sco/sco-main.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:49:36 +0000 (14:49 +0100)]
Bug 7743: Update sco/sco-main.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
12 years agoBug 7743: Update opac-detail.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:43:47 +0000 (14:43 +0100)]
Bug 7743: Update opac-detail.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

12 years agoBug 7743: Update opac-user.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:28:03 +0000 (14:28 +0100)]
Bug 7743: Update opac-user.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
fixed conflict

12 years agoBug 7743: Update opac-tags.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 13:01:14 +0000 (14:01 +0100)]
Bug 7743: Update opac-tags.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
12 years agoBug 7743: Update opac-account.pl to use KohaDates TT plugin
Julian Maurice [Mon, 19 Mar 2012 11:35:41 +0000 (12:35 +0100)]
Bug 7743: Update opac-account.pl to use KohaDates TT plugin

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>