]> git.koha-community.org Git - koha.git/commit
Bug 33238: Fix bad suggestions query (Bug 29886 follow-up)
authorJanusz Kaczmarek <januszop@gmail.com>
Wed, 15 Mar 2023 19:25:53 +0000 (20:25 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 17 Apr 2023 12:39:43 +0000 (09:39 -0300)
commit68b2f29d483290d5dfd859dce9b9fe7a387f3ab1
tree0d90cc051f98060667ce3fffaa67d2f2eef3afbb
parent1344050ab4d2136b06902f1b84a59cc030aa5476
Bug 33238: Fix bad suggestions query (Bug 29886 follow-up)

With IndependentBranches Koha explodes with Error 500 when a non
superlibrarian tries to add to basket from suggestions.  In errorlog you
would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Column 'branchcode' in where clause is
ambiguous".

Test plan:
==========
1. Have a Koha instance with IndependentBranches, some accepted
   suggestions, and a vendor defined.
2. Be a non superlibrarian librarian with permissions to
   manage acquisitions.
3. Create a new basket and try to add an item to the basket
   "From a suggestion".
4. Koha would generate error 500.
5. Apply the patch.
6. Try to add an item to the basket "From a suggestion".
7. You should succeed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Suggestions.pm