]> git.koha-community.org Git - koha.git/commit
Bug 29930: Cardnumber incorrectly set to userid on LDAP auth if cardnumber not mapped
authorJanik Hilser <janik.hilser@icloud.com>
Sun, 20 Feb 2022 17:14:31 +0000 (18:14 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 31 Jan 2024 12:56:32 +0000 (13:56 +0100)
commit884e3d5fe026c254ed1d2467f536e385ec2e7bf4
tree34f0c8000e4a9c6df639fa95528b50a16799a284
parent49c4b0fee0a10d09b0ac35586c6d03fb4c9031df
Bug 29930: Cardnumber incorrectly set to userid on LDAP auth if cardnumber not mapped

In the sub the userId was given, but the cardnumber was expected, therefore at every login the cardnumber changed to the userId.

To test:
1. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId
2. Check the patron record's cardnumber.
3. The cardnumber should equal to the userId
4. Apply the patch.
5. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId
6. Check the patron record's cardnumber.
7. The cardnumber should be the same as before

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Extra test plan:
1. Apply the regression tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Auth_with_ldap.t
=> FAIL: Tests fail! 'cardnumber' incorrectly overwritten
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 6341d520ac0a09baa5b005abb3d8d81273a6e310)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Auth_with_ldap.pm