]> git.koha-community.org Git - koha.git/commit
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 10 Aug 2016 12:04:48 +0000 (13:04 +0100)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Tue, 11 Oct 2016 13:11:55 +0000 (13:11 +0000)
commitbb1e9c500c810402c64436c53bcc00ffb9a0b857
treefaf146ea6a657570c189e4a6175a504503dcf6a7
parent174769e382dfd5205595a5b9ae7b58c8ebf5d850
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description
(lib) for a given authorised value.

We can easily replace it using:
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib
or
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description

Test plan:
- On the detail page of a bibliographic record, the description for notforloan,
restricted and stack (?) should be correctly displayed
- View a shelf, the location (LOC) description should be displayed
- On the search result page, the location description should be displayed in the
  facets
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc. field
should be displayed.
- When creating item in the acquisition module, the dropdown list for
  field linked to AV should display the AV' descriptions
- On the transfers page, the description of the location should be
  displayed.
- On the checkout list from the circulation.pl and returns.pl pages, the
  description for "materials" should be displayed
- Fill some OPAC_SUG AV and create a suggestion, the reason dropdown
  list should display the description of OPAC_SUG

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
C4/Circulation.pm
C4/Items.pm
C4/Koha.pm
C4/Search.pm
acqui/orderreceive.pl
catalogue/getitem-ajax.pl
circ/branchtransfers.pl
circ/circulation.pl
circ/returns.pl
opac/opac-suggestions.pl
serials/subscription-detail.pl