]> git.koha-community.org Git - koha.git/commit
Bug 33470: Don't calculate overridden hold limits
authorNick Clemens <nick@bywatersolutions.com>
Sun, 9 Apr 2023 18:25:41 +0000 (18:25 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 5 May 2023 13:18:37 +0000 (10:18 -0300)
commite3c31212df4d1917004a20998f47777ef0aea35d
treea54dbdc24334cfae131050247578fbdd81586554
parente074ffa6be15c97e6724041b12d930ed70855f1d
Bug 33470: Don't calculate overridden hold limits

This patch can largely be checked in the code to ensure it makes sense, it
moves a conditional up one level for the two different checks that could prevent holds

To test:
1 - Attempt to place a hold via the REST API with an invalid pickup location
    Set pickup location as no in branches to make this easy
2 - Confirm you get an error
3 - Attempt again with header (bug 27760):
    x-koha-override: any
4 - Hold is placed
5 - Repeat 1-4 above but with an item that cannot be held
6 - Apply patch
7 - Repeat 1-4 above
8 - Results should be the same

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/REST/V1/Holds.pm