From 0f00577a9e8a9815058342211ca7ffcc4dc69eeb Mon Sep 17 00:00:00 2001
From: alaurin <alaurin>
Date: Tue, 6 Jun 2006 12:26:57 +0000
Subject: [PATCH] bug fix : for item reservation, now the system don't keep the
 reserve if the document is returned, works fine !!!!

---
 C4/Circulation/Circ2.pm | 2 +-
 circ/circulation.pl     | 1 -
 reserve/placerequest.pl | 1 -
 reserve/request.pl      | 4 ++--
 4 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/C4/Circulation/Circ2.pm b/C4/Circulation/Circ2.pm
index 25dc99aefd..d59223054b 100755
--- a/C4/Circulation/Circ2.pm
+++ b/C4/Circulation/Circ2.pm
@@ -1980,7 +1980,7 @@ sub get_return_date_of {
 SELECT date_due,
        itemnumber
   FROM issues
-  WHERE itemnumber IN ('.join(',', @itemnumbers).')
+  WHERE itemnumber IN ('.join(',', @itemnumbers).') AND returndate IS NULL
 ';
     return get_infos_of($query, 'itemnumber', 'date_due');
 }
diff --git a/circ/circulation.pl b/circ/circulation.pl
index 79f942bb6c..06a617e8ff 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -138,7 +138,6 @@ my $picture;
 if ($borrowernumber) {
     $borrower = getpatroninformation( \%env, $borrowernumber, 0 );
     my ( $od, $issue, $fines ) = borrdata2( \%env, $borrowernumber );
-    warn $borrower->{'expiry'};
     my $warningdate =
       DateCalc( $borrower->{'expiry'},
         "- " . C4::Context->preference('NotifyBorrowerDeparture') . "  days" );
diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
index 00474b9e07..e7716ad8c5 100755
--- a/reserve/placerequest.pl
+++ b/reserve/placerequest.pl
@@ -44,7 +44,6 @@ my @rank=$input->param('rank-request');
 my $type=$input->param('type');
 my $title=$input->param('title');
 my $bornum=borrdata($borrower,'');
-# Nouveau developpement
 my $checkitem=$input->param('checkitem');
 # my $priority;
 my $found;
diff --git a/reserve/request.pl b/reserve/request.pl
index 19dbda0c93..fd62b63aec 100755
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -105,7 +105,7 @@ if ($cardnumber) {
         }
 
 # we check the date expiricy of the borrower
-	my $warning=Date_Cmp(ParseDate("today"),format_date($borrowerinfo->{'expiry'}));
+	my $warning=Date_Cmp(ParseDate("today"),format_date($borrowerinfo->{'dateexpiry'}));
 	if ( $warning > 0) {
 			$expiry = 1;
 	}
@@ -253,7 +253,7 @@ foreach my $biblioitemnumber (@biblioitemnumbers) {
 
         if (defined $return_date_of->{$itemnumber}) {
             $date_due = format_date($return_date_of->{$itemnumber});
-
+	    $item->{date_due} = $date_due;
             $item->{backgroundcolor} = 'onloan';
         }
 
-- 
2.39.5