From 17c7c685f12dd09186d369f84cc725984328c5fa Mon Sep 17 00:00:00 2001 From: Aleisha Date: Mon, 18 Jan 2016 03:30:44 +0000 Subject: [PATCH] Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro Warns are gone. Page still works as expected Signed-off-by: Jonathan Druart Amended patch: -my $phase = $input->param('phase'); -$phase //= ''; +my $phase = $input->param('phase') // ''; Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index 6a03e11dc1..ceba5398af 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -47,7 +47,7 @@ Script to control the guided report creation my $input = new CGI; my $usecache = C4::Context->ismemcached; -my $phase = $input->param('phase'); +my $phase = $input->param('phase') // ''; my $flagsrequired; if ( $phase eq 'Build new' or $phase eq 'Delete Saved' ) { $flagsrequired = 'create_reports'; -- 2.20.1