From 1c6c66c0946fcca0fe480239e17da3546645a3aa Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 6 Feb 2024 16:29:52 +0100
Subject: [PATCH] Bug 34478: Remove form from preferences.tt

We don't need a form here, it's never submitted

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 3 +--
 koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js         | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
index 8349834612..3c8c1c0bc6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
@@ -242,8 +242,7 @@
                     |
                     <a href="#" id="clear_all"><i class="fa fa-times"></i> Clear all</a>
                 </p>
-                <form method="post" action="#" id="prefModalForm">
-                </form>
+                <div id="prefModalBody"></div>
             </div>
             <div class="modal-footer">
                 <button id="saveModalPrefs" data-target="" type="button" class="btn btn-primary">Save</button>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
index 7823d49d72..c0837f730c 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
@@ -330,7 +330,7 @@ $( document ).ready( function () {
         $("<div/>", {
             "class": "columns-2",
             html: items.join("")
-        }).appendTo("#prefModalForm");
+        }).appendTo("#prefModalBody");
 
         $("#saveModalPrefs").data("target", this.id );
         $("#saveModalPrefs").data("type", "modalselect" );
@@ -587,7 +587,7 @@ $( document ).ready( function () {
     });
 
     $("#prefModal").on("hide.bs.modal", function(){
-        $("#prefModalLabel,#prefModalForm").html("");
+        $("#prefModalLabel,#prefModalBody").html("");
         $("#saveModalPrefs").data("target", "" );
     });
 
-- 
2.39.5