From 2d28f7417c4dba186d4f07e98940ed1881c7419c Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 26 May 2023 12:58:22 +0000
Subject: [PATCH] Bug 33844: Fix is_denied_renewal

Going via result_set->has_column does cost actually nothing if
the object is already there.

Test plan:
Run again t/db_dependent/Koha/Item.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 Koha/Item.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Koha/Item.pm b/Koha/Item.pm
index c24339da79..f437fd4215 100644
--- a/Koha/Item.pm
+++ b/Koha/Item.pm
@@ -2065,6 +2065,8 @@ sub is_denied_renewal {
     my $denyingrules = C4::Context->yaml_preference('ItemsDeniedRenewal');
     return 0 unless $denyingrules;
     foreach my $field (keys %$denyingrules) {
+        # Silently ignore bad column names; TODO we should validate elsewhere
+        next if !$self->_result->result_source->has_column($field);
         my $val = $self->$field;
         if( !defined $val) {
             if ( any { !defined $_ }  @{$denyingrules->{$field}} ){
-- 
2.39.5