From 2e818915bec60fd579ed17c45d19b1f32a18e743 Mon Sep 17 00:00:00 2001
From: Emmi Takkinen <emmi.takkinen@outlook.com>
Date: Thu, 9 Jul 2020 11:55:03 +0300
Subject: [PATCH] Bug 16371: Fix QA issues, change terminology

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 Koha/Quote.pm                                                 | 4 ++--
 Koha/Quotes.pm                                                | 4 ++++
 .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt      | 2 +-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Koha/Quote.pm b/Koha/Quote.pm
index f79cf79c3f..244aea0673 100644
--- a/Koha/Quote.pm
+++ b/Koha/Quote.pm
@@ -113,7 +113,7 @@ sub get_daily_quote {
 
 Is a wrapper for get_daily_quote(), with an extra check for using the correct
 interface defined in the syspref 'QuoteOfTheDay'.
-If the current interface is not allowed to display quotes, then returns undef.
+If the current interface is not allowed to display quotes, then returns nothing.
 
 =cut
 
@@ -126,7 +126,7 @@ sub get_daily_quote_for_interface {
         Koha::Exceptions::UnknownProgramState->throw(error => $cc[3]."()> C4::Context->interface() is not set! Don't know are you in OPAC or staff client?");
     }
     unless ($qotdPref =~ /$interface/) {
-        return undef;
+        return;
     }
 
     return $self->get_daily_quote(%opts);
diff --git a/Koha/Quotes.pm b/Koha/Quotes.pm
index 0fe2e167f5..6a9d83af58 100644
--- a/Koha/Quotes.pm
+++ b/Koha/Quotes.pm
@@ -41,6 +41,10 @@ sub _type {
     return 'Quote';
 }
 
+=head3 object_class
+
+=cut
+
 sub object_class {
     return 'Koha::Quote';
 }
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 9fdd12be37..dcf8d39520 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -494,7 +494,7 @@ OPAC:
             - Show quote of the day in the
             - pref: QuoteOfTheDay
               multiple:
-                intranet: staff client
+                intranet: staff interface
                 opac: OPAC
             - main page.
         -
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
index 24d8aa499c..882a446ff1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
@@ -38,7 +38,7 @@
                     <div id="area-news">
                         <h3>Quote of the Day</h3>
                         <div class="newsitem">
-                            <span id="daily-quote-text">[% daily_quote.text %]</span><span id="daily-quote-sep"> ~ </span><span id="daily-quote-source">[% daily_quote.source %]</span>
+                            <span id="daily-quote-text">[% daily_quote.text | html %]</span><span id="daily-quote-sep"> ~ </span><span id="daily-quote-source">[% daily_quote.source | html %]</span>
                         </div>
                     </div>
                 [% END %]
-- 
2.39.5