From 30dd8f99204837e2e76015badd93025599cd552c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 4 Nov 2016 09:46:08 +0100 Subject: [PATCH] Bug 15906: [QA Follow-up] Correct a partial payment The amount in accountlines should be saved as a negative amount, but amount outstanding is correct. Note: This routine is actually used only once (in paycollect.pl). And is only cosmetically tested in Accounts.t. Test plan: [1] Create a manual invoice, Fine, say 20. [2] Click on the Pay button next to this fine, and pay 1. [3] Pay again, using 'Pay amount' button, and pay 2. [4] Pay again, using 'Pay' on the same line, the full remaining amount. [5] Verify that you see -1, -2 and -17 on the Accounts tab. [6] Run t/db_dependent/Accounts.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall --- C4/Accounts.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Accounts.pm b/C4/Accounts.pm index e49becb94c..f65745e9c1 100644 --- a/C4/Accounts.pm +++ b/C4/Accounts.pm @@ -607,7 +607,7 @@ sub makepartialpayment { . 'description, accounttype, amountoutstanding, itemnumber, manager_id, note) ' . ' VALUES (?, ?, now(), ?, ?, ?, 0, ?, ?, ?)'; - $dbh->do( $insert, undef, $borrowernumber, $nextaccntno, $amount, + $dbh->do( $insert, undef, $borrowernumber, $nextaccntno, -$amount, '', 'Pay', $data->{'itemnumber'}, $manager_id, $payment_note); UpdateStats({ -- 2.39.5