From 3b6fd415b450e66058cd97923d9ea68a37223479 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 29 Apr 2022 16:46:24 -1000 Subject: [PATCH] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Fridolin Somers --- suggestion/suggestion.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 5372e00d5b..12eb39f017 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -356,6 +356,11 @@ if ($op=~/else/) { { @criteria_dv = ( C4::Context->userenv->{'branch'} ); } + # Pending tab first + if ( $displayby eq 'STATUS' ) { + @criteria_dv = grep { $_ ne 'ASKED' } @criteria_dv; + unshift @criteria_dv, 'ASKED'; + } my @allsuggestions; foreach my $criteriumvalue ( @criteria_dv ) { -- 2.39.5