From 4261a5193d967e29a9fe93df40f456602edbf01a Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Wed, 8 Apr 2015 12:47:43 +0200
Subject: [PATCH] Bug 9333: Remove useless JS code - confirm close basket

On closing a basket, the librarian is redirect to a new page for the
confirmation, the JavaScript confirmation is useless.

This code is never triggered and can be removed.

Test plan:
Without this patch, confirm you don't get a JavaScript confirmation
popup on closing a basket
With this patch, confirm you don't get any JavaScript error on
closing/reopening a basket.

NOTE: acqui/basket.tt is only used by acqui/basket.pl
      git grep "confirm_close" | grep -v "\.po:"
      doesn't show anything else. Reopening only works on
      basketgroups, not baskets. Unable to trigger any errors
      as expected and desired. :)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
index b68a62b29f..22d66310be 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
@@ -40,12 +40,6 @@
 [% UNLESS ( closedate ) %]
 <script type="text/javascript">
 //<![CDATA[
-            function confirm_close() {
-                var is_confirmed = confirm(_("Are you sure you want to close this basket?"));
-                if (is_confirmed) {
-                    window.location = "[% script_name %]?op=close&basketno=[% basketno %]";
-                }
-            }
 
             function delete_basket(basketno,booksellerid,delbiblio) {
                 window.location = "[% script_name %]?op=delete_confirm&delbiblio="+delbiblio+"&basketno="+basketno+"&booksellerid="+booksellerid;
-- 
2.39.5