From 4921ad8ae42c04415347d2d0bce4a5ed7af395a3 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 29 Jul 2020 20:01:24 +0000 Subject: [PATCH] Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid
- Move heading inside container so that floats clear correctly - Change tag back to
to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../prog/en/modules/catalogue/moredetail.tt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt index 12dc7ea7a2..16fb580bb1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ -29,6 +29,7 @@

[% title | html %]

[% IF ( subtitle ) %]

[% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %]

[% END %] [% IF ( author ) %]

by [% author | html %]

[% END %] +
  1. Biblionumber: [% biblionumber | html %] 
  2. @@ -47,15 +48,18 @@ Show all items[% END %]
+
-
[% IF ( ONLY_ONE ) %] +
You are only viewing one item. View All
[% END %] [% FOREACH ITEM_DAT IN ITEM_DATA %] +

Barcode [% ITEM_DAT.barcode | html %] [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]

-

Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %] + +

Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %] [% IF ( CAN_user_editcatalogue_edit_items ) %] Edit item [% END %] @@ -79,7 +83,7 @@ [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %] )[% END %]

- +
  1. Current location: [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %] 
  2. Checkout status: -- 2.39.5