From 56602217ff5c4ad603e57e5b29d4fefe4922447a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 29 Apr 2022 00:28:33 +0000 Subject: [PATCH] Bug 29346: Use fully qualified names for C4:Circulation routines in C4::HoldsQueue I suppose this is similar to circular dependency on other patch HoldsQueue uses Circulation uses BatchUpdateBiblioHoldsQueueuse HoldsQueue Without this the background job builds the queue, but reports failure: Holds queue for biblio The Jacobite clans of the Great Glen, 1650-1784 /. An error occurred (Undefined subroutine &C4::HoldsQueue::GetTransfers called at /kohadevbox/koha/C4/HoldsQueue.pm line 351. ) Signed-off-by: Nick Clemens Signed-off-by: Fridolin Somers --- C4/HoldsQueue.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index ae93f66dba..f2eb1ee4b8 100644 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -348,9 +348,9 @@ sub GetItemsAvailableToFillHoldRequestsForBib { $sth->execute(@params); my $itm = $sth->fetchall_arrayref({}); - my @items = grep { ! scalar GetTransfers($_->{itemnumber}) } @$itm; + my @items = grep { ! scalar C4::Circulation::GetTransfers($_->{itemnumber}) } @$itm; return [ grep { - my $rule = GetBranchItemRule($_->{homebranch}, $_->{itype}); + my $rule = C4::Circulation::GetBranchItemRule($_->{homebranch}, $_->{itype}); $_->{holdallowed} = $rule->{holdallowed}; $_->{hold_fulfillment_policy} = $rule->{hold_fulfillment_policy}; } @items ]; -- 2.39.5