From 59c569ce92a72dc6d60a16e76fb8c4eebc741fcc Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Mon, 19 May 2014 15:37:34 +0000 Subject: [PATCH] Bug 12243: add regression test This patch adds a regression test for C4::Koha::NormalizeISBN throwing an exception when trying to parse an invalid ISBN. To test: [1] Run prove -v t/Koha.t. The last test should fail. [2] Apply the main patch for this bug. [3] Run prove -v t/Koha.t again. This time, the test should pass. Signed-off-by: Galen Charlton --- t/Koha.t | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/t/Koha.t b/t/Koha.t index 0cdbbb36fd..1f1e4db872 100755 --- a/t/Koha.t +++ b/t/Koha.t @@ -3,7 +3,7 @@ use strict; use warnings; use C4::Context; -use Test::More tests => 14; +use Test::More tests => 15; use Test::MockModule; use DBD::Mock; @@ -67,3 +67,9 @@ my @isbns = qw/ 978-0-321-49694-2 0-321-49694-9 978-0-321-49694-2 0321496949 978 is( join('|', @isbns), join('|', GetVariationsOfISBN('978-0-321-49694-2 (pbk.)')), 'GetVariationsOfISBN returns all variations' ); is( join('|', @isbns), join('|', GetVariationsOfISBNs('978-0-321-49694-2 (pbk.)')), 'GetVariationsOfISBNs returns all variations' ); + +my $isbn; +eval { + $isbn = C4::Koha::NormalizeISBN({ isbn => '0788893777 (2 DVD 45th ed)', format => 'ISBN-10', strip_hyphens => 1 }); +}; +ok($@ eq '', 'NormalizeISBN does not throw exception when parsing invalid ISBN (bug 12243)'); -- 2.39.2