From 61b17625fa388bcff5db5bb7908f8c8332a54f2b Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 28 Jan 2022 13:47:35 +0100
Subject: [PATCH] Bug 29058: Don't display 'Always show holds' at the bottom of
 the patron list

The checkbox should not appear if we are selecting a patron

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/reserve/request.tt        | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 9a46b4ac71..306b8eaca0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -905,16 +905,18 @@
             [% END %]
 
             [% UNLESS ( patron ) %]
-                [% SET hold_count = Biblio.HoldsCount( biblio.biblionumber ) | html %]
-                [% IF hold_count %]
-                    <label for ="always_show_holds">Always show holds</label>
-                    [% IF always_show_holds == 'DONT' %]
-                        <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
-                        [% UNLESS reserveloop %]
-                            <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber | uri %]&show_holds_now=1">Show holds ([% hold_count | html %])</a>
+                [% UNLESS borrowers %]
+                    [% SET hold_count = Biblio.HoldsCount( biblio.biblionumber ) | html %]
+                    [% IF hold_count %]
+                        <label for ="always_show_holds">Always show holds</label>
+                        [% IF always_show_holds == 'DONT' %]
+                            <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
+                            [% UNLESS reserveloop %]
+                                <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber | uri %]&show_holds_now=1">Show holds ([% hold_count | html %])</a>
+                            [% END %]
+                        [% ELSE %]
+                            <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
                         [% END %]
-                    [% ELSE %]
-                        <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
                     [% END %]
                 [% END %]
                 [% IF ( reserveloop ) %]
-- 
2.39.5