From 6d1748ed4c7951040c0aa8ae0489cbdabcf7b732 Mon Sep 17 00:00:00 2001
From: Michael Hafen <michael.hafen@washk12.org>
Date: Wed, 5 Jul 2023 11:17:09 -0600
Subject: [PATCH] Bug 34209: Follow up on Bug 28726 - move whole 'select all
 ...' header into condition

Move the whole search header div into the checkbox column condition, so
that other patron search popups don't have an empty div.

To test:
* Activate the ERM module
* Create a new agreement
* Search for a user using the pop-up search
* Verify there is an empty div showing as grey box above the table
* Go to tools > label creator > new batch
* Search for patrons
* Verify the box isn't empty and shows the select all ... options
* Apply patch
* Repeat steps, verify the empty div is gone and the options remain

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit c2e5a3242529a417d75585af113f6b50e2e690f0)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
index 67f056ddb8..fe854bd58e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
@@ -21,18 +21,18 @@
         </form>
 
         <div id="searchresults">
+        [% IF columns.grep('checkbox').size %]
             <div class="searchheader fh-fixedHeader" id="searchheader" style="display:none;">
                 <div>
-                [% IF columns.grep('checkbox').size %]
                     <a href="#" class="btn btn-link" id="select_all"><i class="fa fa-check"></i> Select all</a>
                     |
                     <a href="#" class="btn btn-link" id="clear_all"><i class="fa fa-remove"></i> Clear all</a>
                     [% IF selection_type == 'add' %]
                     <button id="add-selected" class="btn btn-sm btn-default" type="submit">Add selected patrons</button>
                     [% END %]
-                [% END %]
                 </div>
             </div>
+        [% END %]
         [% PROCESS patron_search_table table_id => 'memberresultst' columns => columns %]
         </div>
 
-- 
2.39.2