From 71b9dc1e3932db29e8fa7a32dd25e7e54c95f228 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 4 Aug 2017 10:44:56 -0300 Subject: [PATCH] Bug 19059: Remove CancelReserve - do not log DELETE There is something wrong with the DELETE log, it should be replaced with a FILLED log. Anyway, here we do not want it to be logged. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- C4/Reserves.pm | 2 +- Koha/Hold.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 20ad806411..697dd66921 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1020,7 +1020,7 @@ sub ModReserveFill { } ); - # FIXME Must call Koha::Hold->cancel ? + # FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add the correct log Koha::Old::Hold->new( $hold->unblessed() )->store(); $hold->delete(); diff --git a/Koha/Hold.pm b/Koha/Hold.pm index 5c6d000ce1..d27bbae693 100644 --- a/Koha/Hold.pm +++ b/Koha/Hold.pm @@ -316,7 +316,7 @@ sub cancel { $self->cancellationdate(dt_from_string); $self->priority(0); $self->_move_to_old; - $self->delete; + $self->SUPER::delete(); # Do not add a DELETE log # now fix the priority on the others.... C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber }); -- 2.39.5