From 783f344a55505fe43d6fee0d37eec88fa4cfb092 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 4 Nov 2022 11:42:47 +0000 Subject: [PATCH] Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Circulation -> Checkout notes - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons - Tools -> OPAC problem reports Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss | 7 +++++++ koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 4 ++-- .../intranet-tmpl/prog/en/modules/circ/checkout-notes.tt | 4 ++-- .../prog/en/modules/tools/batch_delete_records.tt | 4 ++-- .../prog/en/modules/tools/batch_extend_due_dates.tt | 2 +- .../prog/en/modules/tools/batch_record_modification.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 2 +- .../intranet-tmpl/prog/en/modules/tools/problem-reports.tt | 4 ++-- 8 files changed, 19 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss index b85c70aded..4bf8263491 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss @@ -75,4 +75,11 @@ font-size: 100%; } } + + &.selections-toolbar { + a { + display: inline-block; + padding: 0 .5em; + } + } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index c7ac3823c1..52d645f255 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -212,9 +212,9 @@
[% IF display_columns_selection %][%# Needs js/pages/batchMod.js %] [% IF checkboxes_edit OR checkboxes_delete %] -
+
Select all | Clear all | Clear on loan -
+
[% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt index d5bd7db65f..91bd8e61a0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt @@ -69,12 +69,12 @@
-
+
Select all | Clear all | Hide seen | Show all -
+ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt index 9cdef6d7bc..252265f5c9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt @@ -138,7 +138,7 @@ [% ELSIF op == 'list' %] [% IF records %] [% IF recordtype == 'biblio' %] -
+
Select all | Clear all | Select without items @@ -174,7 +174,7 @@
Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!
[% ELSE %] -
+
Select all | Clear all | Clear used authorities diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt index f01d83774f..92b075e68b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt @@ -127,7 +127,7 @@ [% ELSIF view == 'list' %] [% IF checkouts.count %]
-
+
Select all | Clear all
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt index d015745229..aaf1ab9f66 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt @@ -197,7 +197,7 @@
[% IF recordtype == 'biblio' %] -
+
Select all | Clear all
@@ -225,7 +225,7 @@
Reminder: this action will modify all selected biblios!
[% ELSE %] -
+
Select all | Clear all
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index 91d3f803ad..fc666cead9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -201,7 +201,7 @@ [% IF ( borrowers ) %] - +
Select all | Clear all
[% END %] [% END %] [% IF borrowers %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt index 75c1427a00..25577c63df 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt @@ -63,14 +63,14 @@
-
+
Select all | Clear all | Hide viewed | Hide closed | Hide new | Show all -
+
-- 2.39.5