From 7b70f369d58c380b8c3fb8a5b13981776a0945f1 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 18 Sep 2017 15:23:38 +0000
Subject: [PATCH] Bug 19233: (follow-up) Send itemnumbers in report results to
 batch modification

This patch changes the obscure "^" symbol to a styled link with the text
"Batch modify." I think the only disadvantage of this is that it takes
up more space, but it is outweighed by the improved clarity.

This patch also makes minor indentation corrections to new lines of
HTML.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../modules/reports/guided_reports_start.tt   | 60 ++++++++++++-------
 1 file changed, 37 insertions(+), 23 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index 67e8891129..b6fdb0fed8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -37,6 +37,16 @@
     #col1, #col2 { width:45%; float:left; }
     #col1 ins, #col2 del { display: none; }
     .show_sql { font-family: monospace; }
+    .send_to_item_mod {
+        background-color: #EBF3FF;
+        border: 1px solid #88b0e8;
+        border-radius: 5px;
+        display: inline-block;
+        font-size: 75%;
+        margin: 3px 5px;
+        padding: 3px 5px;
+        white-space: nowrap;
+    }
 </style>
 [% IF ( saved1 ) %]
     <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables_[% KOHA_VERSION %].css" />
@@ -705,29 +715,33 @@ canned reports and writing custom SQL reports.</p>
 
 <div class="pages">[% pagination_bar %]</div>
 [% UNLESS ( errors ) %]
-<form method="POST" id="report_results">
-<input type="hidden" name="op" value="show">
-<table>
-<tr>[% FOREACH header_ro IN header_row %]
-        [% IF header_ro.cell == 'itemnumber' %]
-            <th>[% header_ro.cell %] <a href="" data-toggle="tooltip" title="Send visible items to batch modification" class="send_to_item_mod">^</a></th>
-        [% ELSE %]
-            <th>[% header_ro.cell %]</th>
-        [% END %]
-    [% END %]</tr>
-[% FOREACH result IN results %]
-<tr>
-    [% FOREACH cells IN result.cells %]
-        [% place = loop.index %]
-        [% IF header_row.$place.cell == 'itemnumber' %]
-            <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]">
-        [% END %]
-        <td>[% cells.cell %]</td>
-    [% END %]
-</tr>
-[% END %]
-</table>
-</form>
+    <form method="POST" id="report_results">
+        <input type="hidden" name="op" value="show" />
+        <table>
+            <tr>
+                [% FOREACH header_ro IN header_row %]
+                    [% IF header_ro.cell == 'itemnumber' %]
+                        <th>
+                            [% header_ro.cell %] <a href="#" data-toggle="tooltip" title="Send visible items to batch modification" class="send_to_item_mod"><i class="fa fa-pencil"></i> Batch modify</a>
+                        </th>
+                    [% ELSE %]
+                        <th>[% header_ro.cell %]</th>
+                    [% END %]
+                [% END %]
+            </tr>
+            [% FOREACH result IN results %]
+                <tr>
+                    [% FOREACH cells IN result.cells %]
+                        [% place = loop.index %]
+                        [% IF header_row.$place.cell == 'itemnumber' %]
+                            <input type="hidden" name="[% header_row.$place.cell | html %]" value="[% cells.cell | html %]" />
+                        [% END %]
+                        <td>[% cells.cell %]</td>
+                    [% END %]
+                </tr>
+            [% END %]
+        </table>
+    </form>
 [% END %]
 [% END %]
 
-- 
2.39.2