From 7bb9bad4ef5ed493908e0e6a9da9a9ac5f733035 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Mon, 5 Jun 2023 15:38:58 +0000 Subject: [PATCH] Bug 33900: Fix handling of due_digest Test plan, on k-t-d 1) Go to 'my account' 2) On 'Patron messaging preferences', click 'Edit' 3) On the 'Item due' row, check the 'Email' and 'Digests only' checkboxes and save 4) On the top search bar, press 'Check out' and enter '42' (koha user cardnumber) 5) On the checkout input bar, enter a barcode e.g. 39999000001372 and press checkout 6) Run the following query to force the due_date to be equal to 'todays' date: NOTE: change the YYYY-MM-DD below to whatever day it is you're running this test plan UPDATE issues SET date_due = '2023-06-05 23:59:00' where issue_id = 1; 7) Run the cronjob: ./koha/misc/cronjobs/advance_notices.pl -c --digest-per-branch 8) Notice it hangs, it's stuck on an infinite loop on the 2nd while cycle after if () 9) Cancel the cronjob script, apply patch 10) Run the cronjob script again (step 7), notice it finishes 11) Access patron's notices: /cgi-bin/koha/members/notices.pl?borrowernumber=51 Check that the 'Item due reminder' notice is there. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fac7bb247a5a8430152f97727f2cbdd8b4b54e19) Signed-off-by: Martin Renvoize --- misc/cronjobs/advance_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index b13e5cdeba..b0ccd6f1c3 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -419,7 +419,7 @@ if ($digest_per_branch) { while (my ($branchcode, $digests) = each %$due_digest) { send_digests({ sth => $sth_digest, - digests => $due_digest, + digests => $digests, letter_code => 'DUEDGST', branchcode => $branchcode, message_name => 'item_due', -- 2.20.1