From 82eb16325f71b6a72c520e23f1d36f7eb36ecfd0 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 20 Nov 2012 13:53:43 -0500 Subject: [PATCH] Bug 6602 - Reports dictionary doesn't properly recognize text columns Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding a new dictionary definition. Before the patch, in Step 4 you would not see any kind of form field for entering a comparison. After patching Step 4 will offer you a field labeled "Search string matches." Signed-off-by: Melia Meggs Signed-off-by: Katrin Fischer All tests and perlcritic pass. Test plan: 1) Reports > Reports dictionary > New definition 2) Step 1: Some name 3) Step 2: Patrons 4) Step 3: First name (mediumtext) 5) Step 4: Verify 'Search string matches' is offered. For both, surname (mediumtext) and first name (text) the program should offer you "Search string matches" on step 4. Signed-off-by: Jared Camins-Esakov --- reports/dictionary.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/dictionary.pl b/reports/dictionary.pl index aae96c98d8..f27ce105cf 100755 --- a/reports/dictionary.pl +++ b/reports/dictionary.pl @@ -108,7 +108,7 @@ elsif ( $phase eq 'New Term step 4' ) { if ( $type eq 'DATE' || $type eq 'DATETIME' ) { $tmp_hash{'date'} = 1; } - if ( $type eq 'TEXT' ) { + if ($type eq 'TEXT' || $type eq 'MEDIUMTEXT'){ $tmp_hash{'text'} = 1; } -- 2.39.2