From 8382cc9f281e4c12e0e4cf56bfc442506e3f4842 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Wed, 25 Oct 2023 09:39:30 +0000 Subject: [PATCH] Bug 20755: (QA follow-up) Add descriptions to system preferences Updates both the atomic update file and the sysprefs.sql with * explanations for each preference * type = "Free" Signed-off-by: Tomas Cohen Arazi --- ...g_20755-add_acquisitionsdefaultemailaddress_syspref.pl | 8 ++++---- installer/data/mysql/mandatory/sysprefs.sql | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl b/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl index a4f8eb0bbf..394f9f291f 100755 --- a/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl +++ b/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl @@ -9,28 +9,28 @@ return { $dbh->do( q{ - INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultEMailAddress', '', NULL, NULL, NULL); + INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultEMailAddress', '', NULL, "Default email address that acquisition notices are sent from.", 'Free'); } ); say $out "Added new system preference 'AcquisitionsDefaultEMailAddress'"; $dbh->do( q{ - INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultReplyTo', '', NULL, NULL, NULL); + INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the acquisitions module.", 'Free'); } ); say $out "Added new system preference 'AcquisitionsDefaultReplyTo'"; $dbh->do( q{ - INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultEMailAddress', '', NULL, NULL, NULL); + INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultEMailAddress', '', NULL, "Default email address that serials notices are sent from.", 'Free'); } ); say $out "Added new system preference 'SerialsDefaultEMailAddress'"; $dbh->do( q{ - INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultReplyTo', '', NULL, NULL, NULL); + INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the serials module.", 'Free'); } ); say $out "Added new system preference 'SerialsDefaultReplyTo'"; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index 2b0e77aabb..ac82de8f52 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -7,8 +7,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('AcqItemSetSubfieldsWhenReceived','','','Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar")','Free'), ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'), ('AcquisitionLog','0',NULL,'If ON, log acquisitions activity','YesNo'), -('AcquisitionsDefaultEMailAddress', '', NULL, NULL, NULL), -('AcquisitionsDefaultReplyTo', '', NULL, NULL, NULL), +('AcquisitionsDefaultEMailAddress', '', NULL, 'Default email address that acquisition notices are sent from', 'Free'), +('AcquisitionsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the acquisitions module.", 'Free'), ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: their own only, any within their branch, or all','Choice'), ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), ('ActionLogsTraceDepth', '0', '', 'Sets the maximum depth of the action logs stack trace', 'Integer'), @@ -678,8 +678,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), ('SerialsSearchResultsLimit', NULL, NULL, 'Serials search results limit', 'integer'), -('SerialsDefaultEMailAddress', '', NULL, NULL, NULL), -('SerialsDefaultReplyTo', '', NULL, NULL, NULL), +('SerialsDefaultEMailAddress', '', NULL, 'Default email address used as reply-to for notices sent by the serials module.', 'Free'), +('SerialsDefaultReplyTo', '', NULL, 'Default email address that serials notices are sent from.', 'Free'), ('SessionRestrictionByIP','1','Check for change in remote IP address for session security. Disable only when remote IP address changes frequently.','','YesNo'), ('SessionStorage','mysql','mysql|Pg|tmp','Use database or a temporary file for storing session data','Choice'), ('ShelfBrowserUsesCcode','1','0','Use the item collection code when finding items for the shelf browser.','YesNo'), -- 2.39.5