From a42af283176f652a330db54711c64b97ad8faefc Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Fri, 17 Aug 2018 05:26:57 +0000 Subject: [PATCH] Bug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP Test plan: 1) Set up your SIP: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2) Run: misc/sip_cli_emulator.pl -a localhost -p 6001 -su -sp -l --patron -s "Y " -m patron_information the -s parameter says what kind of additional information you want to see 3) Check the response: if the requested patron has waiting hold, there is field "AS" with the barcode of waiting item The right response looks like this: 64 00120180817 052434000100000000000000000000AOCPL|AA1|AEKoha Admin|BLY|CC5|AS39999000004410|PCS|PIY|AFGreetings from Koha. | More reading ;) http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens --- C4/SIP/ILS/Patron.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 41c21a15f2..3d9de0d88d 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -317,7 +317,7 @@ sub hold_items { my $item_arr = $self->x_items('hold_items', @_); foreach my $item (@{$item_arr}) { my $item_obj = Koha::Items->find($item->{itemnumber}); - $item_arr->{barcode} = $item_obj ? $item_obj->barcode : undef; + $item->{barcode} = $item_obj ? $item_obj->barcode : undef; } return $item_arr; } -- 2.39.5