From ac99f64010c6bdbe40abc2b823c2180b9b223425 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 8 Feb 2017 12:41:37 +0100 Subject: [PATCH] Bug 18076: Replace holds_to_place_count with an input type=text From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE """ The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall --- .../intranet-tmpl/prog/en/modules/reserve/request.tt | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 6140472a7b..34a730493d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -426,19 +426,12 @@ function checkMultiHold() { [% IF remaining_holds_for_record > 1 %] - [% SET count = 1 %]
  • - +
    • [% ELSE %] - + [% END %] [% END %] -- 2.39.5