From b60cf7931ab18557b7f507a3c9535ad4bd151c53 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Thu, 6 Oct 2022 10:58:53 -0300
Subject: [PATCH] Bug 17170: (QA follow-up) Escape things, make them
 translatable

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/admin/search_filters.tt      | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt
index 1305177426..b54b7c6f55 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt
@@ -140,15 +140,15 @@
                         "data": function( row, meta, val, type ) {
                             let filter = row;
                             let filter_buttons = '<a class="btn btn-default btn-xs edit_filter" onclick="edit_filter(this)"';
-                            filter_buttons += ' data-filter_id="'+ filter.search_filter_id;
-                            filter_buttons += '" data-filter_name="'+ filter.name;
-                            filter_buttons += '" data-filter_opac="'+ filter.opac;
-                            filter_buttons += '" data-filter_staff_client="'+ filter.staff_client;
-                            filter_buttons += '" ><i class="fa fa-pencil"></i> Edit filter</a>';
-                            filter_buttons += '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/catalogue/search.pl?edit_filter='+filter.search_filter_id+'"><i class="fa fa-search"></i> Edit search</a>';
+                            filter_buttons += ' data-filter_id="'+ escape_str(filter.search_filter_id);
+                            filter_buttons += '" data-filter_name="'+ escape_str(filter.name);
+                            filter_buttons += '" data-filter_opac="'+ escape_str(filter.opac);
+                            filter_buttons += '" data-filter_staff_client="'+ escape_str(filter.staff_client);
+                            filter_buttons += '" ><i class="fa fa-pencil"></i> '+_("Edit filter")+'</a>';
+                            filter_buttons += '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/catalogue/search.pl?edit_filter='+encodeURIComponent(filter.search_filter_id)+'"><i class="fa fa-search"></i> '+ _("Edit search") + '</a>';
                             filter_buttons += '<a class="btn btn-default btn-xs delete_filter" onclick="delete_filter(this)"';
-                            filter_buttons += ' data-filter_id="'+ filter.search_filter_id;
-                            filter_buttons += '"><i class="fa fa-trash"></i> Delete</a>';
+                            filter_buttons += ' data-filter_id="'+ escape_str(filter.search_filter_id);
+                            filter_buttons += '"><i class="fa fa-trash"></i> '+_("Delete")+'</a>';
                             return filter_buttons;
                         },
                         "searchable": false,
-- 
2.39.5