From b8814ff696924c6ebdd5c860da571ac69336fc86 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Fri, 9 Feb 2024 12:59:23 +0000
Subject: [PATCH] Bug 34478: Manual - Replace link with submit button -
 circu-menu

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 7 ++-----
 tools/picture-upload.pl                                | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
index 5ad4a3bcb4..10b1166165 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
@@ -226,12 +226,9 @@
                             <input type="hidden" id="image" name="filetype" value="image" />
                             <input type="hidden" id="cardnumber" name="cardnumber" value="[% patron.cardnumber | html %]" />
                             <input type="hidden" id="borrowernumber" name="borrowernumber" value="[% patron.borrowernumber | html %]" />
-                            <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-upload"></i> Upload photo</button>
-                            <input name="op" type="hidden" value="cud-Upload" />
+                            <button type="submit" class="btn btn-default btn-xs" name="op" value="cud-Upload"><i class="fa fa-upload"></i> Upload photo</button>
                             [% IF ( patron.image ) %]
-                                <a id="delpicture"
-                                    href="/cgi-bin/koha/tools/picture-upload.pl?op=Delete&amp;borrowernumber=[% patron.borrowernumber | html %]&amp;csrf_token=[% csrf_token | html %]"
-                                    class="btn btn-default btn-xs delete"><i class="fa fa-trash-can"></i> Delete</a>
+                            <button id="delpicture" type="submit" class="btn btn-default btn-xs delete" name="op" value="cud-Delete"><i class="fa fa-trash-can"></i> Delete</button>
                             [% END %]
                         </div>
                     </form>
diff --git a/tools/picture-upload.pl b/tools/picture-upload.pl
index 1c0cf9a725..2383fba885 100755
--- a/tools/picture-upload.pl
+++ b/tools/picture-upload.pl
@@ -184,7 +184,7 @@ elsif ( ( $op eq 'cud-Upload' ) && !$uploadfile ) {
     $template->param( cardnumber => $cardnumber );
     $template->param( filetype   => $filetype );
 }
-elsif ( $op eq 'Delete' ) {
+elsif ( $op eq 'cud-Delete' ) {
     my $deleted = eval {
         Koha::Patron::Images->find( $borrowernumber )->delete;
     };
-- 
2.39.5