From bda9b9e122df436d48e6416d140a7bbb45c8546c Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Thu, 4 Mar 2021 17:27:16 +0100 Subject: [PATCH] Bug 27861: Warning in C4/XSLT.pm - use of uninitialized value in numeric eq (==) In C4/XSLT.pm : elsif ( exists $itemtypes->{ $item->effective_itemtype } && $itemtypes->{ $item->effective_itemtype }->{notforloan} == 1 ) itemtype.notforloan is null by default, its generated a warning in logs. Test plan : 1) Choose a record with itemtype.notforloan = NULL 2) Perform a search in the OPAC which will return results which include the record using XSLT 3) See patch removed warning Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart --- C4/XSLT.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 12c97db41e..d4cdb832cd 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -350,6 +350,7 @@ sub buildKohaItemsNamespace { $substatus = exists $descs{$item->notforloan} ? $descs{$item->notforloan}->{opac_description} : "Not for loan"; } elsif ( exists $itemtypes->{ $item->effective_itemtype } + && $itemtypes->{ $item->effective_itemtype }->{notforloan} && $itemtypes->{ $item->effective_itemtype }->{notforloan} == 1 ) { $status = "1" =~ /^($ref_status)$/ -- 2.39.5