From be9dec3e13562fc8b68167b4e1d530d1465187e3 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 20 Oct 2014 12:12:00 -0300 Subject: [PATCH] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard Test plan completed successfully Signed-off-by: Katrin Fischer Passes tests and QA script, works as described. Signed-off-by: Tomas Cohen Arazi --- C4/Search.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index d46b0c5a95..9995ea392e 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -788,11 +788,12 @@ sub _get_facet_from_result_set { my $rs = shift; my $sep = shift; - my $internal_sep = '<*>'; + my $internal_sep = '<*>'; + my $facetMaxCount = C4::Context->preference('FacetMaxCount') // 20; return if ( ! defined $facet_idx || ! defined $rs ); # zebra's facet element, untokenized index - my $facet_element = 'zebra::facet::' . $facet_idx . ':0:100'; + my $facet_element = 'zebra::facet::' . $facet_idx . ':0:' . $facetMaxCount; # configure zebra results for retrieving the desired facet $rs->option( elementSetName => $facet_element ); # get the facet record from result set -- 2.39.5