From bfb798386057b3d3c8847815931bfe7a7f8a302b Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 13 Sep 2019 16:13:33 +0000
Subject: [PATCH] Bug 23602: (follow-up) Correct terminology, add tooltip

This follow-up changes the use of "branch" to the Koha standard
"library." The patch also adds the use of a Bootstrap tooltip for
showing an item type's library limitations in the main table of item
types.

To test, apply the patch and go to Administration -> Item types.

In the table of item types, find one with library limitations. Hovering
over the "# library limitations" test should trigger a Bootstrap-styled
tooltip showing the library name and code.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../prog/en/modules/admin/itemtypes.tt              | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
index 715a71b716..a1b4f1ff8b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ -283,7 +283,7 @@ Item types administration
                         [% END %]
                     </select>
                 </li>
-                <li><label for="branches">Libraries limitation: </label>
+                <li><label for="branches">Library limitation: </label>
                     <select id="branches" name="branches" multiple size="10">
                         <option value="">All libraries</option>
                         [% FOREACH branch IN branches_loop %]
@@ -359,7 +359,7 @@ Item types administration
             <th>Default replacement cost</th>
             <th>Processing fee (when lost)</th>
             <th>Checkin message</th>
-            <th>Branches limitations</th>
+            <th>Library limitations</th>
             <th>Actions</th>
           </thead>
           [% FOREACH itemtype IN itemtypes %]
@@ -416,13 +416,13 @@ Item types administration
                 [% IF itemtype.branches.size > 0 %]
                     [% branches_str = "" %]
                     [% FOREACH branch IN itemtype.branches %]
-                        [% branches_str = branches_str _ " " _ branch.branchname _ "(" _ branch.branchcode _ ")" %]
+                        [% branches_str = branches_str _ " " _ branch.branchname _ " (" _ branch.branchcode _ ")" %]
                     [% END %]
-                    <span href="#" title="[% branches_str | html %]">
+                    <span class="library_limitation" title="[% branches_str | html %]">
                         [% IF itemtype.branches.size > 1 %]
-                            [% itemtype.branches.size | html %] branches limitations
+                            [% itemtype.branches.size | html %] library limitations
                         [% ELSE %]
-                            [% itemtype.branches.size | html %] branch limitation
+                            [% itemtype.branches.size | html %] library limitation
                         [% END %]
                 [% ELSE %]
                     No limitation
@@ -475,6 +475,7 @@ Item types administration
             $("#itemtype").on("blur",function(){
                 toUC(this);
             });
+            $(".library_limitation").tooltip();
          });
     </script>
 [% END %]
-- 
2.39.5