From d1d9a3353502101e6d86411eafe0988bdf2e9185 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 20 Jul 2023 11:24:23 +0000 Subject: [PATCH] Bug 34310: Input prompt in datatables column search boxes untranslatable This patch corrects the internationalization function wrapped around the "% search" string in datatables.js. It should be the double-underscore function instead of the single-underscore. To test, apply the patch and test that the placeholder string is translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/datatables.js for translation, e.g.: \#: koha-tmpl/intranet-tmpl/prog/js/datatables.js:894 \#, javascript-format msgid "%s search" msgstr "%s recherche" - Install the updated translation: > perl translate install fr-FR In the staff interface, test a page that has column header filters, e.g. patron search. Confirm that the table of search results shows the translated string in the column header placeholders. Signed-off-by: Caroline Cyr La Rose Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi (cherry picked from commit c23f36b81218032ed2aa3f2f476fd880e2d1b704) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js index e468f4275b..ee34580112 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js +++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js @@ -891,7 +891,7 @@ function _dt_add_filters(table_node, table_dt, filters_options = {}) { if ( existing_search ) { $(this).html( ''.format(existing_search) ); } else { - var search_title = _("%s search").format(title); + var search_title = __("%s search").format(title); $(this).html( ''.format(search_title) ); } } -- 2.39.2