From f2e8b2b4fda8a5aa102bb1fdb78046397f674a0f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 12 Dec 2012 11:43:27 -0500 Subject: [PATCH] Bug 9276 - Display of biblio-level auth vals on OPAC search broken If you have your MARC framework configured to link a biblio-level field with an authorized value, and that value is linked to an image, and the AuthorisedValueImages system preference is turned on, the OPAC is supposed to display that image in search results much like item type images are displayed if item-level itemtypes are enabled. The switch to Template::Toolkit broke this feature with a variable scope error. This patch corrects the variable scope of the sytem preference check and adds a check for the existence of the image so that the template doesn't try to display broken images. To test: 1. Turn on the AuthorisedValueImages system preference. 2. If necessary, create or configure an authorized value with images. 3. Configure a MARC framework to link a field to the authorized value. I chose an arbitrary field, 942e. 4. Edit a bibliographic record and set a value for the MARC field you configured. 5. Make sure Zebra has reindexed, and perform an OPAC search which will include the record you edited. With AuthorisedValueImages ON, you should see the correct authorized value image. 6. With AuthorisedValueImages OFF, you should see no image. 7. Turn AuthorisedValueImages back on. Edit the authorized value again and configure it with no image. Perform your search again. You should see no image. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov --- koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt index 2e3ad22117..89cc5db404 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ -445,10 +445,12 @@ $(document).ready(function(){ [% END %] [% END %] - [% IF ( SEARCH_RESULT.AuthorisedValueImages ) %] + [% IF ( AuthorisedValueImages ) %] [% FOREACH authorised_value_image IN SEARCH_RESULT.authorised_value_images %] - [% authorised_value_image.label %] + [% IF ( authorised_value_image.imageurl ) %] + [% authorised_value_image.label %] + [% END %] [% END %] [% END %] -- 2.39.5