From fa5c13597b4f7c60378cbbc8be9b67198a0a06d4 Mon Sep 17 00:00:00 2001 From: Caroline Cyr La Rose Date: Wed, 21 Jun 2023 12:27:12 -0400 Subject: [PATCH] Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit To test: 1. Apply patch 2. Install language ./misc/translator/translate install xx-XX 3. Update po files ./misc/translator/translate update xx-XX 4. View the xx-XX-messages.po file --> Strings for tag statuses for one tag should be separated from strings for statuses for multiple tags, with context Tags (single) or Tags (multiple) 5. Change the strings so you know which is which For example, in French, the approved status for a single tag would be "Approuvé" and for multiple tags would be "Approuvés" (with the plural s at the end) 6. Apply translations ./misc/translator/translate install xx-XX 7. Add tags through the OPAC 7.1. In another tab, go to the OPAC 7.2. Log in 7.3. Search for a record 7.4. From the detailed record, click Add tags 7.5. Enter a tag and click Add 8. In the staff interface, go to Tools > Tags 9. Approve/Reject the tag --> The status in the table and on the button should be the singular status, the status in the summary on the right should be plural Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5d23be933f958bf4b3343c41802530088afc0b1d) Signed-off-by: Fridolin Somers (cherry picked from commit ff89574592f7a387cc1c2cc5bdb168cd2b1f9361) Signed-off-by: Matt Blenkinsop --- .../prog/en/modules/tags/review.tt | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt index e259217ff9..efcd8203d7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt @@ -1,6 +1,7 @@ [% USE raw %] [% USE Asset %] [% USE KohaDates %] +[% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] [% IF ( do_it ) %]Review[% ELSE %]Review tags[% END %] › Tags › Tools › Koha @@ -110,15 +111,15 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; } [% IF ( tagloo.approved == -1 ) %] [% ELSIF ( tagloo.approved == 1 ) %] [% ELSE %] [% END %] @@ -130,9 +131,9 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; } @@ -167,13 +168,13 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; }

Terms summary