]> git.koha-community.org Git - koha.git/commit
Bug 25527: Add logger to Koha::ExternalContent
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 18 May 2020 12:26:09 +0000 (09:26 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 18 May 2020 14:25:03 +0000 (15:25 +0100)
commit05705ab2ad12aff3627eb53e7e4d56d6a4b20bcd
tree83a6da8cb4600fd7edbb49e73d0d1da85ee740e7
parent48e3e6aafb04fbe6eea33da8550c9952a3f52a11
Bug 25527: Add logger to Koha::ExternalContent

This patch makes Koha::Logger initialization happen in the ->new method
for the Koha::ExternalContent-derived classes. In the case of RecordedBooks,
it doesn't look like it is used at all.

In the case of OverDrive, it will now use the Koha::ExternalContent
exported logger accessor.

I added tests for this addition to Koha::ExternalContent to the
OverDrive tests.

I also removed references to Test::DBIx::Class as it is not used at all.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha_ExternalContent_OverDrive.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/ExternalContent.pm
Koha/ExternalContent/OverDrive.pm
Koha/ExternalContent/RecordedBooks.pm
t/db_dependent/Koha_ExternalContent_OverDrive.t